Skip to content

Rebase: kcp-0.7+ / kube 1.24 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 8, 2022
Merged

Rebase: kcp-0.7+ / kube 1.24 #21

merged 5 commits into from
Aug 8, 2022

Conversation

ncdc
Copy link
Member

@ncdc ncdc commented Jul 29, 2022

No description provided.

@ncdc
Copy link
Member Author

ncdc commented Jul 29, 2022

Working on getting prow set up. Please hold off merging for now

@ncdc ncdc force-pushed the kcp/rebase-1.24 branch from edcd5a2 to 4a90459 Compare July 29, 2022 17:57
ncdc and others added 5 commits August 5, 2022 13:41
@ncdc @fabianvf
UPSTREAM: <carry>: support preexisting http.Clients
b07f7e8 
Co-authored-by: Fabian von Feilitzsch <[email protected]>
@ncdc @fabianvf
UPSTREAM: <carry>: support custom informer creation + indexers
108fafd 
Co-authored-by: Fabian von Feilitzsch <[email protected]>
@ncdc @fabianvf
UPSTREAM: <carry>: support logical clusters
68d02b3 
Signed-off-by: Andy Goldstein <[email protected]>
Co-authored-by: Fabian von Feilitzsch <[email protected]>
@ncdc @fabianvf
UPSTREAM: <carry>: add cluster-aware manager, client, etc
4e85147 
Signed-off-by: Andy Goldstein <[email protected]>
Co-authored-by: Fabian von Feilitzsch <[email protected]>
@ncdc
UPSTREAM: <carry>: move to logicalcluster/v2
989a925 
Signed-off-by: Andy Goldstein <[email protected]>
@ncdc ncdc force-pushed the kcp/rebase-1.24 branch 2 times, most recently from 989a925 to 4e85147 Compare August 5, 2022 17:54
@ncdc ncdc requested a review from fabianvf August 5, 2022 18:49
@ncdc ncdc marked this pull request as draft August 5, 2022 18:49
@ncdc ncdc marked this pull request as ready for review August 8, 2022 14:53
@ncdc
Copy link
Member Author

ncdc commented Aug 8, 2022

/test all

@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2022

@ncdc: No presubmit jobs available for kcp-dev/[email protected]

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevekuznetsov
Copy link

/test all

@stevekuznetsov
Copy link

Something seems goofy in compilation

@ncdc
Copy link
Member Author

ncdc commented Aug 8, 2022

Yeah, not sure if it's a 1.17 vs 1.18 issue, or what's going on

@stevekuznetsov
Copy link

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
@openshift-merge-robot openshift-merge-robot merged commit 4b60fd6 into kcp-dev:kcp-1.24 Aug 8, 2022
@ncdc ncdc mentioned this pull request Aug 8, 2022
Closed
@stevekuznetsov stevekuznetsov mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianvf fabianvf Awaiting requested review from fabianvf

Assignees

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncdc @stevekuznetsov @openshift-merge-robot