Skip to content

UPSTREAM: <carry>: Support cluster-aware APIReader client #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2022
Merged

UPSTREAM: <carry>: Support cluster-aware APIReader client #24

merged 1 commit into from
Sep 2, 2022

Conversation

astefanutti
Copy link
Member

@astefanutti astefanutti commented Sep 1, 2022

Fixes #23.

@stevekuznetsov
Copy link

I understand the approach but if we are to propose this upstream, having a user-provided (but defaulted) factory for this read-only/live client would make more sense in the context of how the rest of this library works.

@astefanutti
Copy link
Member Author

I understand the approach but if we are to propose this upstream, having a user-provided (but defaulted) factory for this read-only/live client would make more sense in the context of how the rest of this library works.

Thanks and agreed. I've re-pushed with the new factory approach to be consistent with the existing extension model.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2022
@openshift-merge-robot openshift-merge-robot merged commit 824b15a into kcp-dev:kcp-1.24 Sep 2, 2022
@astefanutti astefanutti deleted the pr-apireader branch October 6, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APIReader client is not cluster-aware
3 participants