Address review comments

Author: DougGregor

Sources/SwiftDriver/Driver/CompilerMode.swift

@@ -28,7 +28,7 @@ public enum CompilerMode: Equatable {
   case immediate
 
   /// Compile a Clang module (.pcm).
-  case compilePcm
+  case compilePCM
 }
 
 /// Information about batch mode, which is used to determine how to form
@@ -43,7 +43,7 @@ extension CompilerMode {
   /// Whether this compilation mode uses -primary-file to specify its inputs.
   public var usesPrimaryFileInputs: Bool {
     switch self {
-    case .immediate, .repl, .singleCompile, .compilePcm:
+    case .immediate, .repl, .singleCompile, .compilePCM:
       return false
 
     case .standardCompile, .batchCompile:
@@ -57,7 +57,7 @@ extension CompilerMode {
     case .immediate, .repl, .standardCompile, .batchCompile:
       return false
 
-    case .singleCompile, .compilePcm:
+    case .singleCompile, .compilePCM:
       return true
     }
   }
@@ -76,7 +76,7 @@ extension CompilerMode: CustomStringConvertible {
         return "read-eval-print-loop compilation"
       case .immediate:
         return "immediate compilation"
-      case .compilePcm:
+      case .compilePCM:
         return "compile Clang module (.pcm)"
       }
   }

Sources/SwiftDriver/Driver/Driver.swift

@@ -702,7 +702,7 @@ extension Driver {
         return .repl
 
       case .emitPcm:
-        return .compilePcm
+        return .compilePCM
 
       default:
         // Output flag doesn't determine the compiler mode.

Sources/SwiftDriver/Incremental Compilation/IncrementalCompilation.swift

@@ -154,7 +154,7 @@ fileprivate extension CompilerMode {
   var supportsIncrementalCompilation: Bool {
     switch self {
     case .standardCompile, .immediate, .repl, .batchCompile: return true
-    case .singleCompile, .compilePcm: return false
+    case .singleCompile, .compilePCM: return false
     }
   }
 }

Sources/SwiftDriver/Jobs/FrontendJobHelpers.swift

@@ -43,7 +43,7 @@ extension Driver {
     // Only pass -target to the REPL or immediate modes if it was explicitly
     // specified on the command line.
     switch compilerMode {
-    case .standardCompile, .singleCompile, .batchCompile, .compilePcm:
+    case .standardCompile, .singleCompile, .batchCompile, .compilePCM:
       commandLine.appendFlag(.target)
       commandLine.appendFlag(targetTriple.triple)
 

Sources/SwiftDriver/Jobs/GeneratePCMJob.swift

@@ -38,7 +38,8 @@ extension Driver {
                      type: .pcm)
     } else {
       output = .init(
-        file: try VirtualPath(path: moduleName + "." + FileType.pcm.name),
+        file: try VirtualPath(
+          path: moduleName.appendingFileTypeExtension(.pcm)),
         type: .pcm)
     }
 

Sources/SwiftDriver/Jobs/Planning.swift

@@ -67,7 +67,7 @@ extension Driver {
     case .batchCompile(let batchInfo):
       partitions = batchPartitions(batchInfo)
 
-    case .immediate, .repl, .compilePcm:
+    case .immediate, .repl, .compilePCM:
       fatalError("compiler mode \(compilerMode) is handled elsewhere")
 
     case .singleCompile:
@@ -181,7 +181,7 @@ extension Driver {
     case .standardCompile, .batchCompile, .singleCompile:
       return try planStandardCompile()
 
-    case .compilePcm:
+    case .compilePCM:
       if inputFiles.count != 1 {
         throw PlanningError.emitPCMWrongInputFiles
       }