Skip to content

Commit 051d51b

Browse files
error27gregkh
authored andcommitted
efivars: memory leak on error in create_efivars_bin_attributes()
This is a cut and paste bug. We intended to free ->del_var and ->new_var but we only free ->new_var. Signed-off-by: Dan Carpenter <[email protected]> Acked-by: Mike Waychison <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent bcdd323 commit 051d51b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/firmware/efivars.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -677,8 +677,8 @@ create_efivars_bin_attributes(struct efivars *efivars)
677677

678678
return 0;
679679
out_free:
680-
kfree(efivars->new_var);
681-
efivars->new_var = NULL;
680+
kfree(efivars->del_var);
681+
efivars->del_var = NULL;
682682
kfree(efivars->new_var);
683683
efivars->new_var = NULL;
684684
return error;

0 commit comments

Comments
 (0)