Skip to content

Commit 06a0df4

Browse files
committed
fbcon: remove now unusued 'softback_lines' cursor() argument
Since the softscroll code got removed, this argument is always zero and makes no sense any more. Tested-by: Yuan Ming <[email protected]> Tested-by: Willy Tarreau <[email protected]> Reviewed-by: Greg Kroah-Hartman <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent 5014547 commit 06a0df4

File tree

7 files changed

+8
-44
lines changed

7 files changed

+8
-44
lines changed

drivers/video/fbdev/core/bitblit.c

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ static void bit_clear_margins(struct vc_data *vc, struct fb_info *info,
234234
}
235235

236236
static void bit_cursor(struct vc_data *vc, struct fb_info *info, int mode,
237-
int softback_lines, int fg, int bg)
237+
int fg, int bg)
238238
{
239239
struct fb_cursor cursor;
240240
struct fbcon_ops *ops = info->fbcon_par;
@@ -247,15 +247,6 @@ static void bit_cursor(struct vc_data *vc, struct fb_info *info, int mode,
247247

248248
cursor.set = 0;
249249

250-
if (softback_lines) {
251-
if (y + softback_lines >= vc->vc_rows) {
252-
mode = CM_ERASE;
253-
ops->cursor_flash = 0;
254-
return;
255-
} else
256-
y += softback_lines;
257-
}
258-
259250
c = scr_readw((u16 *) vc->vc_pos);
260251
attribute = get_attribute(info, c);
261252
src = vc->vc_font.data + ((c & charmask) * (w * vc->vc_font.height));

drivers/video/fbdev/core/fbcon.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ static void fb_flashcursor(struct work_struct *work)
394394
c = scr_readw((u16 *) vc->vc_pos);
395395
mode = (!ops->cursor_flash || ops->cursor_state.enable) ?
396396
CM_ERASE : CM_DRAW;
397-
ops->cursor(vc, info, mode, 0, get_color(vc, info, c, 1),
397+
ops->cursor(vc, info, mode, get_color(vc, info, c, 1),
398398
get_color(vc, info, c, 0));
399399
console_unlock();
400400
}
@@ -1345,7 +1345,7 @@ static void fbcon_cursor(struct vc_data *vc, int mode)
13451345

13461346
ops->cursor_flash = (mode == CM_ERASE) ? 0 : 1;
13471347

1348-
ops->cursor(vc, info, mode, 0, get_color(vc, info, c, 1),
1348+
ops->cursor(vc, info, mode, get_color(vc, info, c, 1),
13491349
get_color(vc, info, c, 0));
13501350
}
13511351

drivers/video/fbdev/core/fbcon.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ struct fbcon_ops {
6262
void (*clear_margins)(struct vc_data *vc, struct fb_info *info,
6363
int color, int bottom_only);
6464
void (*cursor)(struct vc_data *vc, struct fb_info *info, int mode,
65-
int softback_lines, int fg, int bg);
65+
int fg, int bg);
6666
int (*update_start)(struct fb_info *info);
6767
int (*rotate_font)(struct fb_info *info, struct vc_data *vc);
6868
struct fb_var_screeninfo var; /* copy of the current fb_var_screeninfo */

drivers/video/fbdev/core/fbcon_ccw.c

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ static void ccw_clear_margins(struct vc_data *vc, struct fb_info *info,
219219
}
220220

221221
static void ccw_cursor(struct vc_data *vc, struct fb_info *info, int mode,
222-
int softback_lines, int fg, int bg)
222+
int fg, int bg)
223223
{
224224
struct fb_cursor cursor;
225225
struct fbcon_ops *ops = info->fbcon_par;
@@ -236,15 +236,6 @@ static void ccw_cursor(struct vc_data *vc, struct fb_info *info, int mode,
236236

237237
cursor.set = 0;
238238

239-
if (softback_lines) {
240-
if (y + softback_lines >= vc->vc_rows) {
241-
mode = CM_ERASE;
242-
ops->cursor_flash = 0;
243-
return;
244-
} else
245-
y += softback_lines;
246-
}
247-
248239
c = scr_readw((u16 *) vc->vc_pos);
249240
attribute = get_attribute(info, c);
250241
src = ops->fontbuffer + ((c & charmask) * (w * vc->vc_font.width));

drivers/video/fbdev/core/fbcon_cw.c

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ static void cw_clear_margins(struct vc_data *vc, struct fb_info *info,
202202
}
203203

204204
static void cw_cursor(struct vc_data *vc, struct fb_info *info, int mode,
205-
int softback_lines, int fg, int bg)
205+
int fg, int bg)
206206
{
207207
struct fb_cursor cursor;
208208
struct fbcon_ops *ops = info->fbcon_par;
@@ -219,15 +219,6 @@ static void cw_cursor(struct vc_data *vc, struct fb_info *info, int mode,
219219

220220
cursor.set = 0;
221221

222-
if (softback_lines) {
223-
if (y + softback_lines >= vc->vc_rows) {
224-
mode = CM_ERASE;
225-
ops->cursor_flash = 0;
226-
return;
227-
} else
228-
y += softback_lines;
229-
}
230-
231222
c = scr_readw((u16 *) vc->vc_pos);
232223
attribute = get_attribute(info, c);
233224
src = ops->fontbuffer + ((c & charmask) * (w * vc->vc_font.width));

drivers/video/fbdev/core/fbcon_ud.c

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@ static void ud_clear_margins(struct vc_data *vc, struct fb_info *info,
249249
}
250250

251251
static void ud_cursor(struct vc_data *vc, struct fb_info *info, int mode,
252-
int softback_lines, int fg, int bg)
252+
int fg, int bg)
253253
{
254254
struct fb_cursor cursor;
255255
struct fbcon_ops *ops = info->fbcon_par;
@@ -267,15 +267,6 @@ static void ud_cursor(struct vc_data *vc, struct fb_info *info, int mode,
267267

268268
cursor.set = 0;
269269

270-
if (softback_lines) {
271-
if (y + softback_lines >= vc->vc_rows) {
272-
mode = CM_ERASE;
273-
ops->cursor_flash = 0;
274-
return;
275-
} else
276-
y += softback_lines;
277-
}
278-
279270
c = scr_readw((u16 *) vc->vc_pos);
280271
attribute = get_attribute(info, c);
281272
src = ops->fontbuffer + ((c & charmask) * (w * vc->vc_font.height));

drivers/video/fbdev/core/tileblit.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ static void tile_clear_margins(struct vc_data *vc, struct fb_info *info,
8080
}
8181

8282
static void tile_cursor(struct vc_data *vc, struct fb_info *info, int mode,
83-
int softback_lines, int fg, int bg)
83+
int fg, int bg)
8484
{
8585
struct fb_tilecursor cursor;
8686
int use_sw = vc->vc_cursor_type & CUR_SW;

0 commit comments

Comments
 (0)