Skip to content

Commit 0d55bab

Browse files
committed
drm/i915: Drop stray clearing of rps->last_adj
We used to reset last_adj to 0 on crossing a power domain boundary, to slow down our rate of change. However, commit 60548c5 ("drm/i915: Interactive RPS mode") accidentally caused it to be reset on every frequency update, nerfing the fast response granted by the slow start algorithm. Fixes: 60548c5 ("drm/i915: Interactive RPS mode") Testcase: igt/pm_rps/mix-max-config-loaded Signed-off-by: Chris Wilson <[email protected]> Cc: Joonas Lahtinen <[email protected]> Reviewed-by: Mika Kuoppala <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent d0f5cc5 commit 0d55bab

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

drivers/gpu/drm/i915/intel_pm.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6371,7 +6371,6 @@ static void gen6_set_rps_thresholds(struct drm_i915_private *dev_priv, u8 val)
63716371
new_power = HIGH_POWER;
63726372
rps_set_power(dev_priv, new_power);
63736373
mutex_unlock(&rps->power.mutex);
6374-
rps->last_adj = 0;
63756374
}
63766375

63776376
void intel_rps_mark_interactive(struct drm_i915_private *i915, bool interactive)

0 commit comments

Comments
 (0)