Skip to content

Commit 0f6938e

Browse files
chleroydavem330
authored andcommitted
net: core: Use csum_replace_by_diff() and csum_sub() instead of opencoding
Open coded calculation can be avoided and replaced by the equivalent csum_replace_by_diff() and csum_sub(). Signed-off-by: Christophe Leroy <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent adfb62d commit 0f6938e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

net/core/utils.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -476,9 +476,9 @@ void inet_proto_csum_replace_by_diff(__sum16 *sum, struct sk_buff *skb,
476476
__wsum diff, bool pseudohdr)
477477
{
478478
if (skb->ip_summed != CHECKSUM_PARTIAL) {
479-
*sum = csum_fold(csum_add(diff, ~csum_unfold(*sum)));
479+
csum_replace_by_diff(sum, diff);
480480
if (skb->ip_summed == CHECKSUM_COMPLETE && pseudohdr)
481-
skb->csum = ~csum_add(diff, ~skb->csum);
481+
skb->csum = ~csum_sub(diff, skb->csum);
482482
} else if (pseudohdr) {
483483
*sum = ~csum_fold(csum_add(diff, csum_unfold(*sum)));
484484
}

0 commit comments

Comments
 (0)