Skip to content

Commit 13b152a

Browse files
KanjiMonsterkuba-moo
authored andcommitted
net: dsa: b53: always rejoin default untagged VLAN on bridge leave
While JOIN_ALL_VLAN allows to join all VLANs, we still need to keep the default VLAN enabled so that untagged traffic stays untagged. So rejoin the default VLAN even for switches with JOIN_ALL_VLAN support. Fixes: 48aea33 ("net: dsa: b53: Add JOIN_ALL_VLAN support") Signed-off-by: Jonas Gorski <[email protected]> Tested-by: Florian Fainelli <[email protected]> Reviewed-by: Florian Fainelli <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent a1c1901 commit 13b152a

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

drivers/net/dsa/b53/b53_common.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2021,12 +2021,12 @@ void b53_br_leave(struct dsa_switch *ds, int port, struct dsa_bridge bridge)
20212021
if (!(reg & BIT(cpu_port)))
20222022
reg |= BIT(cpu_port);
20232023
b53_write16(dev, B53_VLAN_PAGE, B53_JOIN_ALL_VLAN_EN, reg);
2024-
} else {
2025-
b53_get_vlan_entry(dev, pvid, vl);
2026-
vl->members |= BIT(port) | BIT(cpu_port);
2027-
vl->untag |= BIT(port) | BIT(cpu_port);
2028-
b53_set_vlan_entry(dev, pvid, vl);
20292024
}
2025+
2026+
b53_get_vlan_entry(dev, pvid, vl);
2027+
vl->members |= BIT(port) | BIT(cpu_port);
2028+
vl->untag |= BIT(port) | BIT(cpu_port);
2029+
b53_set_vlan_entry(dev, pvid, vl);
20302030
}
20312031
EXPORT_SYMBOL(b53_br_leave);
20322032

0 commit comments

Comments
 (0)