Skip to content

Commit 188107b

Browse files
committed
selftests: net: bump GRO timeout for gro/setup_veth
Commit 51bef03 ("selftests/net: deflake GRO tests") recently switched to NAPI suspension, and lowered the timeout from 1ms to 100us. This started causing flakes in netdev-run CI. Let's bump it to 200us. In a quick test of a debug kernel I see failures with 100us, with 200us in 5 runs I see 2 completely clean runs and 3 with a single retry (GRO test will retry up to 5 times). Reviewed-by: Kevin Krakauer <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent adbf627 commit 188107b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/testing/selftests/net/setup_veth.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ setup_veth_ns() {
1111
local -r ns_mac="$4"
1212

1313
[[ -e /var/run/netns/"${ns_name}" ]] || ip netns add "${ns_name}"
14-
echo 100000 > "/sys/class/net/${ns_dev}/gro_flush_timeout"
14+
echo 200000 > "/sys/class/net/${ns_dev}/gro_flush_timeout"
1515
echo 1 > "/sys/class/net/${ns_dev}/napi_defer_hard_irqs"
1616
ip link set dev "${ns_dev}" netns "${ns_name}" mtu 65535
1717
ip -netns "${ns_name}" link set dev "${ns_dev}" up

0 commit comments

Comments
 (0)