Skip to content

Commit 1cbd788

Browse files
vsyrjalaalexdeucher
authored andcommitted
drm/amdgpu: Remove pointless on stack mode copies
These on stack copies of the modes appear to be pointless. Just look at the originals directly. Cc: Harry Wentland <[email protected]> Cc: Leo Li <[email protected]> Cc: Rodrigo Siqueira <[email protected]> Cc: Alex Deucher <[email protected]> Cc: [email protected] Cc: Nikola Cornij <[email protected]> Cc: Aurabindo Pillai <[email protected]> Reviewed-by: Harry Wentland <[email protected]> Signed-off-by: Ville Syrjälä <[email protected]> Signed-off-by: Alex Deucher <[email protected]>
1 parent 508a47d commit 1cbd788

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -10181,27 +10181,27 @@ static bool
1018110181
is_timing_unchanged_for_freesync(struct drm_crtc_state *old_crtc_state,
1018210182
struct drm_crtc_state *new_crtc_state)
1018310183
{
10184-
struct drm_display_mode old_mode, new_mode;
10184+
const struct drm_display_mode *old_mode, *new_mode;
1018510185

1018610186
if (!old_crtc_state || !new_crtc_state)
1018710187
return false;
1018810188

10189-
old_mode = old_crtc_state->mode;
10190-
new_mode = new_crtc_state->mode;
10191-
10192-
if (old_mode.clock == new_mode.clock &&
10193-
old_mode.hdisplay == new_mode.hdisplay &&
10194-
old_mode.vdisplay == new_mode.vdisplay &&
10195-
old_mode.htotal == new_mode.htotal &&
10196-
old_mode.vtotal != new_mode.vtotal &&
10197-
old_mode.hsync_start == new_mode.hsync_start &&
10198-
old_mode.vsync_start != new_mode.vsync_start &&
10199-
old_mode.hsync_end == new_mode.hsync_end &&
10200-
old_mode.vsync_end != new_mode.vsync_end &&
10201-
old_mode.hskew == new_mode.hskew &&
10202-
old_mode.vscan == new_mode.vscan &&
10203-
(old_mode.vsync_end - old_mode.vsync_start) ==
10204-
(new_mode.vsync_end - new_mode.vsync_start))
10189+
old_mode = &old_crtc_state->mode;
10190+
new_mode = &new_crtc_state->mode;
10191+
10192+
if (old_mode->clock == new_mode->clock &&
10193+
old_mode->hdisplay == new_mode->hdisplay &&
10194+
old_mode->vdisplay == new_mode->vdisplay &&
10195+
old_mode->htotal == new_mode->htotal &&
10196+
old_mode->vtotal != new_mode->vtotal &&
10197+
old_mode->hsync_start == new_mode->hsync_start &&
10198+
old_mode->vsync_start != new_mode->vsync_start &&
10199+
old_mode->hsync_end == new_mode->hsync_end &&
10200+
old_mode->vsync_end != new_mode->vsync_end &&
10201+
old_mode->hskew == new_mode->hskew &&
10202+
old_mode->vscan == new_mode->vscan &&
10203+
(old_mode->vsync_end - old_mode->vsync_start) ==
10204+
(new_mode->vsync_end - new_mode->vsync_start))
1020510205
return true;
1020610206

1020710207
return false;

0 commit comments

Comments
 (0)