Skip to content

Commit 2562d67

Browse files
committed
revert "memfd: improve userspace warnings for missing exec-related flags".
This warning is telling userspace developers to pass MFD_EXEC and MFD_NOEXEC_SEAL to memfd_create(). Commit 434ed33 ("memfd: improve userspace warnings for missing exec-related flags") made the warning more frequent and visible in the hope that this would accelerate the fixing of errant userspace. But the overall effect is to generate far too much dmesg noise. Fixes: 434ed33 ("memfd: improve userspace warnings for missing exec-related flags") Reported-by: Damian Tometzki <[email protected]> Closes: https://lkml.kernel.org/r/[email protected] Cc: Aleksa Sarai <[email protected]> Cc: Christian Brauner <[email protected]> Cc: Daniel Verkamp <[email protected]> Cc: Jeff Xu <[email protected]> Cc: Kees Cook <[email protected]> Cc: Shuah Khan <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent c83ad36 commit 2562d67

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mm/memfd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ SYSCALL_DEFINE2(memfd_create,
316316
return -EINVAL;
317317

318318
if (!(flags & (MFD_EXEC | MFD_NOEXEC_SEAL))) {
319-
pr_info_ratelimited(
319+
pr_warn_once(
320320
"%s[%d]: memfd_create() called without MFD_EXEC or MFD_NOEXEC_SEAL set\n",
321321
current->comm, task_pid_nr(current));
322322
}

0 commit comments

Comments
 (0)