Skip to content

Commit 27493cb

Browse files
committed
drm/i915/display/dmc: Set DC_STATE_DEBUG_MASK_CORES after firmware load
Specification asks for DC_STATE_DEBUG_MASK_CORES to be set for all platforms that supports DMC, not only for geminilake and broxton. While at is also taking the oportunity to simply the code. BSpec: 7402 BSpec: 49436 Reviewed-by: Imre Deak <[email protected]> Cc: Imre Deak <[email protected]> Cc: Gwan-gyeong Mun <[email protected]> Signed-off-by: José Roberto de Souza <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 3d1adc3 commit 27493cb

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

drivers/gpu/drm/i915/display/intel_dmc.c

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -255,20 +255,10 @@ intel_get_stepping_info(struct drm_i915_private *i915,
255255

256256
static void gen9_set_dc_state_debugmask(struct drm_i915_private *dev_priv)
257257
{
258-
u32 val, mask;
259-
260-
mask = DC_STATE_DEBUG_MASK_MEMORY_UP;
261-
262-
if (IS_GEMINILAKE(dev_priv) || IS_BROXTON(dev_priv))
263-
mask |= DC_STATE_DEBUG_MASK_CORES;
264-
265258
/* The below bit doesn't need to be cleared ever afterwards */
266-
val = intel_de_read(dev_priv, DC_STATE_DEBUG);
267-
if ((val & mask) != mask) {
268-
val |= mask;
269-
intel_de_write(dev_priv, DC_STATE_DEBUG, val);
270-
intel_de_posting_read(dev_priv, DC_STATE_DEBUG);
271-
}
259+
intel_de_rmw(dev_priv, DC_STATE_DEBUG, 0,
260+
DC_STATE_DEBUG_MASK_CORES | DC_STATE_DEBUG_MASK_MEMORY_UP);
261+
intel_de_posting_read(dev_priv, DC_STATE_DEBUG);
272262
}
273263

274264
/**

0 commit comments

Comments
 (0)