Skip to content

Commit 2cbece6

Browse files
Zhang Zekunkuba-moo
authored andcommitted
net: hns3: Use ARRAY_SIZE() to improve readability
There is a helper function ARRAY_SIZE() to help calculating the u32 array size, and we don't need to do it mannually. So, let's use ARRAY_SIZE() to calculate the array size, and improve the code readability. Signed-off-by: Zhang Zekun <[email protected]> Reviewed-by: Jijie Shao<[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 555e553 commit 2cbece6

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_regs.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -134,17 +134,17 @@ void hclgevf_get_regs(struct hnae3_handle *handle, u32 *version,
134134
reg += hclgevf_reg_get_header(reg);
135135

136136
/* fetching per-VF registers values from VF PCIe register space */
137-
reg_um = sizeof(cmdq_reg_addr_list) / sizeof(u32);
137+
reg_um = ARRAY_SIZE(cmdq_reg_addr_list);
138138
reg += hclgevf_reg_get_tlv(HCLGEVF_REG_TAG_CMDQ, reg_um, reg);
139139
for (i = 0; i < reg_um; i++)
140140
*reg++ = hclgevf_read_dev(&hdev->hw, cmdq_reg_addr_list[i]);
141141

142-
reg_um = sizeof(common_reg_addr_list) / sizeof(u32);
142+
reg_um = ARRAY_SIZE(common_reg_addr_list);
143143
reg += hclgevf_reg_get_tlv(HCLGEVF_REG_TAG_COMMON, reg_um, reg);
144144
for (i = 0; i < reg_um; i++)
145145
*reg++ = hclgevf_read_dev(&hdev->hw, common_reg_addr_list[i]);
146146

147-
reg_um = sizeof(ring_reg_addr_list) / sizeof(u32);
147+
reg_um = ARRAY_SIZE(ring_reg_addr_list);
148148
for (j = 0; j < hdev->num_tqps; j++) {
149149
reg += hclgevf_reg_get_tlv(HCLGEVF_REG_TAG_RING, reg_um, reg);
150150
for (i = 0; i < reg_um; i++)
@@ -153,7 +153,7 @@ void hclgevf_get_regs(struct hnae3_handle *handle, u32 *version,
153153
HCLGEVF_RING_REG_OFFSET * j);
154154
}
155155

156-
reg_um = sizeof(tqp_intr_reg_addr_list) / sizeof(u32);
156+
reg_um = ARRAY_SIZE(tqp_intr_reg_addr_list);
157157
for (j = 0; j < hdev->num_msi_used - 1; j++) {
158158
reg += hclgevf_reg_get_tlv(HCLGEVF_REG_TAG_TQP_INTR, reg_um, reg);
159159
for (i = 0; i < reg_um; i++)

0 commit comments

Comments
 (0)