Skip to content

Commit 368be1c

Browse files
Andre Edichdavem330
authored andcommitted
smsc95xx: remove redundant function arguments
This patch removes arguments netdev and phy_id from the functions smsc95xx_mdio_read_nopm and smsc95xx_mdio_write_nopm. Both removed arguments are recovered from a new argument `struct usbnet *dev`. Signed-off-by: Andre Edich <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent ae9a138 commit 368be1c

File tree

1 file changed

+17
-18
lines changed

1 file changed

+17
-18
lines changed

drivers/net/usb/smsc95xx.c

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -261,16 +261,18 @@ static void __smsc95xx_mdio_write(struct net_device *netdev, int phy_id,
261261
mutex_unlock(&dev->phy_mutex);
262262
}
263263

264-
static int smsc95xx_mdio_read_nopm(struct net_device *netdev, int phy_id,
265-
int idx)
264+
static int smsc95xx_mdio_read_nopm(struct usbnet *dev, int idx)
266265
{
267-
return __smsc95xx_mdio_read(netdev, phy_id, idx, 1);
266+
struct mii_if_info *mii = &dev->mii;
267+
268+
return __smsc95xx_mdio_read(dev->net, mii->phy_id, idx, 1);
268269
}
269270

270-
static void smsc95xx_mdio_write_nopm(struct net_device *netdev, int phy_id,
271-
int idx, int regval)
271+
static void smsc95xx_mdio_write_nopm(struct usbnet *dev, int idx, int regval)
272272
{
273-
__smsc95xx_mdio_write(netdev, phy_id, idx, regval, 1);
273+
struct mii_if_info *mii = &dev->mii;
274+
275+
__smsc95xx_mdio_write(dev->net, mii->phy_id, idx, regval, 1);
274276
}
275277

276278
static int smsc95xx_mdio_read(struct net_device *netdev, int phy_id, int idx)
@@ -1347,39 +1349,37 @@ static u32 smsc_crc(const u8 *buffer, size_t len, int filter)
13471349

13481350
static int smsc95xx_enable_phy_wakeup_interrupts(struct usbnet *dev, u16 mask)
13491351
{
1350-
struct mii_if_info *mii = &dev->mii;
13511352
int ret;
13521353

13531354
netdev_dbg(dev->net, "enabling PHY wakeup interrupts\n");
13541355

13551356
/* read to clear */
1356-
ret = smsc95xx_mdio_read_nopm(dev->net, mii->phy_id, PHY_INT_SRC);
1357+
ret = smsc95xx_mdio_read_nopm(dev, PHY_INT_SRC);
13571358
if (ret < 0)
13581359
return ret;
13591360

13601361
/* enable interrupt source */
1361-
ret = smsc95xx_mdio_read_nopm(dev->net, mii->phy_id, PHY_INT_MASK);
1362+
ret = smsc95xx_mdio_read_nopm(dev, PHY_INT_MASK);
13621363
if (ret < 0)
13631364
return ret;
13641365

13651366
ret |= mask;
13661367

1367-
smsc95xx_mdio_write_nopm(dev->net, mii->phy_id, PHY_INT_MASK, ret);
1368+
smsc95xx_mdio_write_nopm(dev, PHY_INT_MASK, ret);
13681369

13691370
return 0;
13701371
}
13711372

13721373
static int smsc95xx_link_ok_nopm(struct usbnet *dev)
13731374
{
1374-
struct mii_if_info *mii = &dev->mii;
13751375
int ret;
13761376

13771377
/* first, a dummy read, needed to latch some MII phys */
1378-
ret = smsc95xx_mdio_read_nopm(dev->net, mii->phy_id, MII_BMSR);
1378+
ret = smsc95xx_mdio_read_nopm(dev, MII_BMSR);
13791379
if (ret < 0)
13801380
return ret;
13811381

1382-
ret = smsc95xx_mdio_read_nopm(dev->net, mii->phy_id, MII_BMSR);
1382+
ret = smsc95xx_mdio_read_nopm(dev, MII_BMSR);
13831383
if (ret < 0)
13841384
return ret;
13851385

@@ -1428,25 +1428,24 @@ static int smsc95xx_enter_suspend0(struct usbnet *dev)
14281428
static int smsc95xx_enter_suspend1(struct usbnet *dev)
14291429
{
14301430
struct smsc95xx_priv *pdata = (struct smsc95xx_priv *)(dev->data[0]);
1431-
struct mii_if_info *mii = &dev->mii;
14321431
u32 val;
14331432
int ret;
14341433

14351434
/* reconfigure link pulse detection timing for
14361435
* compatibility with non-standard link partners
14371436
*/
14381437
if (pdata->features & FEATURE_PHY_NLP_CROSSOVER)
1439-
smsc95xx_mdio_write_nopm(dev->net, mii->phy_id, PHY_EDPD_CONFIG,
1440-
PHY_EDPD_CONFIG_DEFAULT);
1438+
smsc95xx_mdio_write_nopm(dev, PHY_EDPD_CONFIG,
1439+
PHY_EDPD_CONFIG_DEFAULT);
14411440

14421441
/* enable energy detect power-down mode */
1443-
ret = smsc95xx_mdio_read_nopm(dev->net, mii->phy_id, PHY_MODE_CTRL_STS);
1442+
ret = smsc95xx_mdio_read_nopm(dev, PHY_MODE_CTRL_STS);
14441443
if (ret < 0)
14451444
return ret;
14461445

14471446
ret |= MODE_CTRL_STS_EDPWRDOWN_;
14481447

1449-
smsc95xx_mdio_write_nopm(dev->net, mii->phy_id, PHY_MODE_CTRL_STS, ret);
1448+
smsc95xx_mdio_write_nopm(dev, PHY_MODE_CTRL_STS, ret);
14501449

14511450
/* enter SUSPEND1 mode */
14521451
ret = smsc95xx_read_reg_nopm(dev, PM_CTRL, &val);

0 commit comments

Comments
 (0)