Skip to content

Commit 388cdf3

Browse files
bcopelandlinvjw
authored andcommitted
ath5k: fix endianness of bitwise ops when installing mic
Fix these bugs found by sparse: ath5k/pcu.c:1102:21: warning: restricted __le32 degrades to integer ath5k/pcu.c:1102:13: warning: incorrect type in assignment (different base types) ath5k/pcu.c:1102:13: expected restricted __le32 <noident> ath5k/pcu.c:1102:13: got unsigned int ath5k/pcu.c:1104:20: warning: restricted __le32 degrades to integer ath5k/pcu.c:1104:13: warning: incorrect type in assignment (different base types) ath5k/pcu.c:1104:13: expected restricted __le32 <noident> ath5k/pcu.c:1104:13: got unsigned int Changes-licensed-under: ISC Reported-by: Johannes Berg <[email protected]> Signed-off-by: Bob Copeland <[email protected]> Signed-off-by: John W. Linville <[email protected]>
1 parent 62d714e commit 388cdf3

File tree

1 file changed

+2
-2
lines changed
  • drivers/net/wireless/ath5k

1 file changed

+2
-2
lines changed

drivers/net/wireless/ath5k/pcu.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1099,9 +1099,9 @@ int ath5k_hw_set_key(struct ath5k_hw *ah, u16 entry,
10991099

11001100
if (ah->ah_combined_mic) {
11011101
key_v[0] = rxmic[0];
1102-
key_v[1] = (txmic[0] >> 16) & 0xffff;
1102+
key_v[1] = cpu_to_le32(le32_to_cpu(txmic[0]) >> 16);
11031103
key_v[2] = rxmic[1];
1104-
key_v[3] = txmic[0] & 0xffff;
1104+
key_v[3] = cpu_to_le32(le32_to_cpu(txmic[0]) & 0xffff);
11051105
key_v[4] = txmic[1];
11061106
} else {
11071107
key_v[0] = rxmic[0];

0 commit comments

Comments
 (0)