Skip to content

Commit 499b702

Browse files
kilroydlinvjw
authored andcommitted
orinoco: Fix inappropriate use of IRQ_BAP
This hardware buffer should only be used from an interrupt. The wireless event generation functions are called from a workqueue, so use USER_BAP instead. Signed-off-by: David Kilroy <[email protected]> Signed-off-by: Pavel Roskin <[email protected]> Signed-off-by: John W. Linville <[email protected]>
1 parent 0c06dd8 commit 499b702

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/net/wireless/orinoco/orinoco.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1750,7 +1750,7 @@ static void orinoco_send_bssid_wevent(struct orinoco_private *priv)
17501750
union iwreq_data wrqu;
17511751
int err;
17521752

1753-
err = hermes_read_ltv(hw, IRQ_BAP, HERMES_RID_CURRENTBSSID,
1753+
err = hermes_read_ltv(hw, USER_BAP, HERMES_RID_CURRENTBSSID,
17541754
ETH_ALEN, NULL, wrqu.ap_addr.sa_data);
17551755
if (err != 0)
17561756
return;
@@ -1773,7 +1773,7 @@ static void orinoco_send_assocreqie_wevent(struct orinoco_private *priv)
17731773
if (!priv->has_wpa)
17741774
return;
17751775

1776-
err = hermes_read_ltv(hw, IRQ_BAP, HERMES_RID_CURRENT_ASSOC_REQ_INFO,
1776+
err = hermes_read_ltv(hw, USER_BAP, HERMES_RID_CURRENT_ASSOC_REQ_INFO,
17771777
sizeof(buf), NULL, &buf);
17781778
if (err != 0)
17791779
return;
@@ -1803,7 +1803,7 @@ static void orinoco_send_assocrespie_wevent(struct orinoco_private *priv)
18031803
if (!priv->has_wpa)
18041804
return;
18051805

1806-
err = hermes_read_ltv(hw, IRQ_BAP, HERMES_RID_CURRENT_ASSOC_RESP_INFO,
1806+
err = hermes_read_ltv(hw, USER_BAP, HERMES_RID_CURRENT_ASSOC_RESP_INFO,
18071807
sizeof(buf), NULL, &buf);
18081808
if (err != 0)
18091809
return;

0 commit comments

Comments
 (0)