Skip to content

Commit 5ea0d42

Browse files
KanjiMonsterPaolo Abeni
authored andcommitted
net: dsa: b53: allow RGMII for bcm63xx RGMII ports
Add RGMII to supported interfaces for BCM63xx RGMII ports so they can be actually used in RGMII mode. Without this, phylink will fail to configure them: [ 3.580000] b53-switch 10700000.switch GbE3 (uninitialized): validation of rgmii with support 0000000,00000000,00000000,000062ff and advertisement 0000000,00000000,00000000,000062ff failed: -EINVAL [ 3.600000] b53-switch 10700000.switch GbE3 (uninitialized): failed to connect to PHY: -EINVAL [ 3.610000] b53-switch 10700000.switch GbE3 (uninitialized): error -22 setting up PHY for tree 0, switch 0, port 4 Fixes: ce3bf94 ("net: dsa: b53: add support for BCM63xx RGMIIs") Reviewed-by: Florian Fainelli <[email protected]> Signed-off-by: Jonas Gorski <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Paolo Abeni <[email protected]>
1 parent 75f4f7b commit 5ea0d42

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/net/dsa/b53/b53_common.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1439,6 +1439,10 @@ static void b53_phylink_get_caps(struct dsa_switch *ds, int port,
14391439
__set_bit(PHY_INTERFACE_MODE_MII, config->supported_interfaces);
14401440
__set_bit(PHY_INTERFACE_MODE_REVMII, config->supported_interfaces);
14411441

1442+
/* BCM63xx RGMII ports support RGMII */
1443+
if (is63xx(dev) && in_range(port, B53_63XX_RGMII0, 4))
1444+
phy_interface_set_rgmii(config->supported_interfaces);
1445+
14421446
config->mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE |
14431447
MAC_10 | MAC_100;
14441448

0 commit comments

Comments
 (0)