Skip to content

Commit 6c46ad4

Browse files
daniellertskuba-moo
authored andcommitted
selftests: mlxsw: sharedbuffer: Remove duplicate test cases
On both port_tc_ip_test() and port_tc_arp_test(), the max occupancy is checked on $h2 twice, when only the error message is different and does not match the check itself. Remove the two duplicated test cases from the test. Fixes: a865ad9 ("selftests: mlxsw: Add shared buffer traffic test") Signed-off-by: Danielle Ratson <[email protected]> Reviewed-by: Ido Schimmel <[email protected]> Signed-off-by: Ido Schimmel <[email protected]> Signed-off-by: Petr Machata <[email protected]> Link: https://patch.msgid.link/d9eb26f6fc16a06a30b5c2c16ad80caf502bc561.1733414773.git.petrm@nvidia.com Signed-off-by: Jakub Kicinski <[email protected]>
1 parent cf3515c commit 6c46ad4

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

tools/testing/selftests/drivers/net/mlxsw/sharedbuffer.sh

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -131,11 +131,6 @@ port_tc_ip_test()
131131

132132
devlink sb occupancy snapshot $DEVLINK_DEV
133133

134-
RET=0
135-
max_occ=$(sb_occ_itc_check $dl_port2 $SB_ITC $exp_max_occ)
136-
check_err $? "Expected ingress TC($SB_ITC) max occupancy to be $exp_max_occ, but got $max_occ"
137-
log_test "physical port's($h1) ingress TC - IP packet"
138-
139134
RET=0
140135
max_occ=$(sb_occ_itc_check $dl_port2 $SB_ITC $exp_max_occ)
141136
check_err $? "Expected ingress TC($SB_ITC) max occupancy to be $exp_max_occ, but got $max_occ"
@@ -158,11 +153,6 @@ port_tc_arp_test()
158153

159154
devlink sb occupancy snapshot $DEVLINK_DEV
160155

161-
RET=0
162-
max_occ=$(sb_occ_itc_check $dl_port2 $SB_ITC $exp_max_occ)
163-
check_err $? "Expected ingress TC($SB_ITC) max occupancy to be $exp_max_occ, but got $max_occ"
164-
log_test "physical port's($h1) ingress TC - ARP packet"
165-
166156
RET=0
167157
max_occ=$(sb_occ_itc_check $dl_port2 $SB_ITC $exp_max_occ)
168158
check_err $? "Expected ingress TC($SB_ITC) max occupancy to be $exp_max_occ, but got $max_occ"

0 commit comments

Comments
 (0)