Skip to content

Commit 6c90731

Browse files
karstengrdavem330
authored andcommitted
net/smc: add missing error check in smc_clc_prfx_set()
Coverity stumbled over a missing error check in smc_clc_prfx_set(): *** CID 1475954: Error handling issues (CHECKED_RETURN) /net/smc/smc_clc.c: 233 in smc_clc_prfx_set() >>> CID 1475954: Error handling issues (CHECKED_RETURN) >>> Calling "kernel_getsockname" without checking return value (as is done elsewhere 8 out of 10 times). 233 kernel_getsockname(clcsock, (struct sockaddr *)&addrs); Add the return code check in smc_clc_prfx_set(). Fixes: c246d94 ("net/smc: restructure netinfo for CLC proposal msgs") Reported-by: Julian Wiedmann <[email protected]> Signed-off-by: Karsten Graul <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 36747c9 commit 6c90731

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

net/smc/smc_clc.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,8 @@ static int smc_clc_prfx_set(struct socket *clcsock,
230230
goto out_rel;
231231
}
232232
/* get address to which the internal TCP socket is bound */
233-
kernel_getsockname(clcsock, (struct sockaddr *)&addrs);
233+
if (kernel_getsockname(clcsock, (struct sockaddr *)&addrs) < 0)
234+
goto out_rel;
234235
/* analyze IP specific data of net_device belonging to TCP socket */
235236
addr6 = (struct sockaddr_in6 *)&addrs;
236237
rcu_read_lock();

0 commit comments

Comments
 (0)