Skip to content

Commit 6d20fae

Browse files
GustavoARSilvadavem330
authored andcommitted
isdn_common: Mark expected switch fall-throughs
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/isdn/i4l/isdn_common.c: In function ‘isdn_wildmat’: drivers/isdn/i4l/isdn_common.c:173:5: warning: this statement may fall through [-Wimplicit-fallthrough=] p++; ~^~ drivers/isdn/i4l/isdn_common.c:174:3: note: here default: ^~~~~~~ CC [M] drivers/leds/leds-lp8788.o CC [M] drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/smu10_smumgr.o drivers/isdn/i4l/isdn_common.c: In function ‘isdn_status_callback’: drivers/isdn/i4l/isdn_common.c:729:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (divert_if) ^ drivers/isdn/i4l/isdn_common.c:732:2: note: here default: ^~~~~~~ Warning level 3 was used: -Wimplicit-fallthrough=3 Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find. This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 023fb4b commit 6d20fae

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

drivers/isdn/i4l/isdn_common.c

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -166,11 +166,9 @@ isdn_wildmat(char *s, char *p)
166166
for (; *p; s++, p++)
167167
switch (*p) {
168168
case '\\':
169-
/*
170-
* Literal match with following character,
171-
* fall through.
172-
*/
169+
/* Literal match with following character. */
173170
p++;
171+
/* fall through */
174172
default:
175173
if (*s != *p)
176174
return (*s == '\0') ? 2 : 1;
@@ -729,6 +727,7 @@ isdn_status_callback(isdn_ctrl *c)
729727
if (divert_if)
730728
return (divert_if->stat_callback(c));
731729
#endif /* CONFIG_ISDN_DIVERSION */
730+
/* fall through */
732731
default:
733732
return -1;
734733
}

0 commit comments

Comments
 (0)