Skip to content

Commit a1e36ec

Browse files
matttbePaolo Abeni
authored andcommitted
selftests: drv-net: fix merge conflicts resolution
After the recent merge between net-next and net, I got some conflicts on my side because the merge resolution was different from Stephen's one [1] I applied on my side in the MPTCP tree. It looks like the code that is now in net-next is using the old way to retrieve the local and remote addresses. This patch is now using the new way, like what was in Stephen's email [1]. Also, in get_interface_info(), there were no conflicts in this area, because that was new code from 'net', but a small adaptation was needed there as well to get the remote address. Fixes: 941defc ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net") Link: https://lore.kernel.org/[email protected] [1] Suggested-by: Stephen Rothwell <[email protected]> Signed-off-by: Matthieu Baerts (NGI0) <[email protected]> Link: https://patch.msgid.link/20250314-net-next-drv-net-ping-fix-merge-v1-1-0d5c19daf707@kernel.org Signed-off-by: Paolo Abeni <[email protected]>
1 parent 941defc commit a1e36ec

File tree

1 file changed

+9
-9
lines changed
  • tools/testing/selftests/drivers/net

1 file changed

+9
-9
lines changed

tools/testing/selftests/drivers/net/ping.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,18 @@
1515
def _test_v4(cfg) -> None:
1616
cfg.require_ipver("4")
1717

18-
cmd(f"ping -c 1 -W0.5 {cfg.remote_v4}")
19-
cmd(f"ping -c 1 -W0.5 {cfg.v4}", host=cfg.remote)
20-
cmd(f"ping -s 65000 -c 1 -W0.5 {cfg.remote_v4}")
21-
cmd(f"ping -s 65000 -c 1 -W0.5 {cfg.v4}", host=cfg.remote)
18+
cmd("ping -c 1 -W0.5 " + cfg.remote_addr_v["4"])
19+
cmd("ping -c 1 -W0.5 " + cfg.addr_v["4"], host=cfg.remote)
20+
cmd("ping -s 65000 -c 1 -W0.5 " + cfg.remote_addr_v["4"])
21+
cmd("ping -s 65000 -c 1 -W0.5 " + cfg.addr_v["4"], host=cfg.remote)
2222

2323
def _test_v6(cfg) -> None:
2424
cfg.require_ipver("6")
2525

26-
cmd(f"ping -c 1 -W5 {cfg.remote_v6}")
27-
cmd(f"ping -c 1 -W5 {cfg.v6}", host=cfg.remote)
28-
cmd(f"ping -s 65000 -c 1 -W0.5 {cfg.remote_v6}")
29-
cmd(f"ping -s 65000 -c 1 -W0.5 {cfg.v6}", host=cfg.remote)
26+
cmd("ping -c 1 -W5 " + cfg.remote_addr_v["6"])
27+
cmd("ping -c 1 -W5 " + cfg.addr_v["6"], host=cfg.remote)
28+
cmd("ping -s 65000 -c 1 -W0.5 " + cfg.remote_addr_v["6"])
29+
cmd("ping -s 65000 -c 1 -W0.5 " + cfg.addr_v["6"], host=cfg.remote)
3030

3131
def _test_tcp(cfg) -> None:
3232
cfg.require_cmd("socat", remote=True)
@@ -120,7 +120,7 @@ def get_interface_info(cfg) -> None:
120120
global remote_ifname
121121
global no_sleep
122122

123-
remote_info = cmd(f"ip -4 -o addr show to {cfg.remote_v4} | awk '{{print $2}}'", shell=True, host=cfg.remote).stdout
123+
remote_info = cmd(f"ip -4 -o addr show to {cfg.remote_addr_v['4']} | awk '{{print $2}}'", shell=True, host=cfg.remote).stdout
124124
remote_ifname = remote_info.rstrip('\n')
125125
if remote_ifname == "":
126126
raise KsftFailEx('Can not get remote interface')

0 commit comments

Comments
 (0)