Skip to content

Commit a80d8fb

Browse files
oleremkuba-moo
authored andcommitted
net: phy: dp83td510: add SQI support
Convert MSE (mean-square error) values to SNR and split it SQI (Signal Quality Indicator) ranges. The used ranges are taken from "OPEN ALLIANCE - Advanced diagnostic features for 100BASE-T1 automotive Ethernet PHYs" specification. Signed-off-by: Oleksij Rempel <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent b1f01b4 commit a80d8fb

File tree

1 file changed

+49
-0
lines changed

1 file changed

+49
-0
lines changed

drivers/net/phy/dp83td510.c

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,27 @@
2727
#define DP83TD510E_AN_STAT_1 0x60c
2828
#define DP83TD510E_MASTER_SLAVE_RESOL_FAIL BIT(15)
2929

30+
#define DP83TD510E_MSE_DETECT 0xa85
31+
32+
#define DP83TD510_SQI_MAX 7
33+
34+
/* Register values are converted to SNR(dB) as suggested by
35+
* "Application Report - DP83TD510E Cable Diagnostics Toolkit":
36+
* SNR(dB) = -10 * log10 (VAL/2^17) - 1.76 dB.
37+
* SQI ranges are implemented according to "OPEN ALLIANCE - Advanced diagnostic
38+
* features for 100BASE-T1 automotive Ethernet PHYs"
39+
*/
40+
static const u16 dp83td510_mse_sqi_map[] = {
41+
0x0569, /* < 18dB */
42+
0x044c, /* 18dB =< SNR < 19dB */
43+
0x0369, /* 19dB =< SNR < 20dB */
44+
0x02b6, /* 20dB =< SNR < 21dB */
45+
0x0227, /* 21dB =< SNR < 22dB */
46+
0x01b6, /* 22dB =< SNR < 23dB */
47+
0x015b, /* 23dB =< SNR < 24dB */
48+
0x0000 /* 24dB =< SNR */
49+
};
50+
3051
static int dp83td510_config_intr(struct phy_device *phydev)
3152
{
3253
int ret;
@@ -164,6 +185,32 @@ static int dp83td510_config_aneg(struct phy_device *phydev)
164185
return genphy_c45_check_and_restart_aneg(phydev, changed);
165186
}
166187

188+
static int dp83td510_get_sqi(struct phy_device *phydev)
189+
{
190+
int sqi, ret;
191+
u16 mse_val;
192+
193+
if (!phydev->link)
194+
return 0;
195+
196+
ret = phy_read_mmd(phydev, MDIO_MMD_VEND2, DP83TD510E_MSE_DETECT);
197+
if (ret < 0)
198+
return ret;
199+
200+
mse_val = 0xFFFF & ret;
201+
for (sqi = 0; sqi < ARRAY_SIZE(dp83td510_mse_sqi_map); sqi++) {
202+
if (mse_val >= dp83td510_mse_sqi_map[sqi])
203+
return sqi;
204+
}
205+
206+
return -EINVAL;
207+
}
208+
209+
static int dp83td510_get_sqi_max(struct phy_device *phydev)
210+
{
211+
return DP83TD510_SQI_MAX;
212+
}
213+
167214
static int dp83td510_get_features(struct phy_device *phydev)
168215
{
169216
/* This PHY can't respond on MDIO bus if no RMII clock is enabled.
@@ -192,6 +239,8 @@ static struct phy_driver dp83td510_driver[] = {
192239
.get_features = dp83td510_get_features,
193240
.config_intr = dp83td510_config_intr,
194241
.handle_interrupt = dp83td510_handle_interrupt,
242+
.get_sqi = dp83td510_get_sqi,
243+
.get_sqi_max = dp83td510_get_sqi_max,
195244

196245
.suspend = genphy_suspend,
197246
.resume = genphy_resume,

0 commit comments

Comments
 (0)