Skip to content

Commit aa444fc

Browse files
icklezhenyw
authored andcommitted
drm/i915/gvt: cleanup debugfs scan_nonprivbb
Remove extra chatty message for debugfs scan_nonprivbb which is used to enable scan for non privileged batch on specific engine. Just write target i915 engine mask instead. Cc: Ding Zhuocheng <[email protected]> Signed-off-by: Chris Wilson <[email protected]> Acked-by: Zhenyu Wang <[email protected]> Signed-off-by: Zhenyu Wang <[email protected]> Link: http://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent 135dde8 commit aa444fc

File tree

1 file changed

+1
-35
lines changed

1 file changed

+1
-35
lines changed

drivers/gpu/drm/i915/gvt/debugfs.c

Lines changed: 1 addition & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ static int
128128
vgpu_scan_nonprivbb_get(void *data, u64 *val)
129129
{
130130
struct intel_vgpu *vgpu = (struct intel_vgpu *)data;
131+
131132
*val = vgpu->scan_nonprivbb;
132133
return 0;
133134
}
@@ -142,42 +143,7 @@ static int
142143
vgpu_scan_nonprivbb_set(void *data, u64 val)
143144
{
144145
struct intel_vgpu *vgpu = (struct intel_vgpu *)data;
145-
struct drm_i915_private *dev_priv = vgpu->gvt->dev_priv;
146-
enum intel_engine_id id;
147-
char buf[128], *s;
148-
int len;
149-
150-
val &= (1 << I915_NUM_ENGINES) - 1;
151-
152-
if (vgpu->scan_nonprivbb == val)
153-
return 0;
154-
155-
if (!val)
156-
goto done;
157-
158-
len = sprintf(buf,
159-
"gvt: vgpu %d turns on non-privileged batch buffers scanning on Engines:",
160-
vgpu->id);
161-
162-
s = buf + len;
163-
164-
for (id = 0; id < I915_NUM_ENGINES; id++) {
165-
struct intel_engine_cs *engine;
166-
167-
engine = dev_priv->engine[id];
168-
if (engine && (val & (1 << id))) {
169-
len = snprintf(s, 4, "%d, ", engine->id);
170-
s += len;
171-
} else
172-
val &= ~(1 << id);
173-
}
174-
175-
if (val)
176-
sprintf(s, "low performance expected.");
177-
178-
pr_warn("%s\n", buf);
179146

180-
done:
181147
vgpu->scan_nonprivbb = val;
182148
return 0;
183149
}

0 commit comments

Comments
 (0)