fs/ntfs3: uninitialized variable in ntfs_set_acl_ex()

Dan Carpenter · aalexandrovich · commit d4073595d0c6 · 2022-08-10T19:12:58.000+03:00
The goto out calls kfree(value) on an uninitialized pointer. Just return directly as the other error paths do. Fixes: 460bbf2 ("fs/ntfs3: Do not change mode if ntfs_set_ea failed") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c
@@ -568,7 +568,7 @@ static noinline int ntfs_set_acl_ex(struct user_namespace *mnt_userns,
 			err = posix_acl_update_mode(mnt_userns, inode, &mode,
 						    &acl);
 			if (err)
-				goto out;
+				return err;
 		}
 		name = XATTR_NAME_POSIX_ACL_ACCESS;
 		name_len = sizeof(XATTR_NAME_POSIX_ACL_ACCESS) - 1;

Original file line number	Diff line number	Diff line change
`@@ -568,7 +568,7 @@ static noinline int ntfs_set_acl_ex(struct user_namespace *mnt_userns,`
`568`	`568`	`err = posix_acl_update_mode(mnt_userns, inode, &mode,`
`569`	`569`	`&acl);`
`570`	`570`	`if (err)`
`571`		`- goto out;`
	`571`	`+ return err;`
`572`	`572`	`}`
`573`	`573`	`name = XATTR_NAME_POSIX_ACL_ACCESS;`
`574`	`574`	`name_len = sizeof(XATTR_NAME_POSIX_ACL_ACCESS) - 1;`