Skip to content

Commit d5449ff

Browse files
axiqiavinodkoul
authored andcommitted
dmaengine: idxd: Add missing idxd cleanup to fix memory leak in remove call
The remove call stack is missing idxd cleanup to free bitmap, ida and the idxd_device. Call idxd_free() helper routines to make sure we exit gracefully. Fixes: bfe1d56 ("dmaengine: idxd: Init and probe for Intel data accelerators") Cc: [email protected] Suggested-by: Vinicius Costa Gomes <[email protected]> Signed-off-by: Shuai Xue <[email protected]> Reviewed-by: Fenghua Yu <[email protected]> Reviewed-by: Dave Jiang <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]>
1 parent 90022b3 commit d5449ff

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/dma/idxd/init.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1335,6 +1335,7 @@ static void idxd_remove(struct pci_dev *pdev)
13351335
destroy_workqueue(idxd->wq);
13361336
perfmon_pmu_remove(idxd);
13371337
put_device(idxd_confdev(idxd));
1338+
idxd_free(idxd);
13381339
}
13391340

13401341
static struct pci_driver idxd_pci_driver = {

0 commit comments

Comments
 (0)