Skip to content

Commit da62b49

Browse files
ukleinekalexandrebelloni
authored andcommitted
rtc: test: Also test time and wday outcome of rtc_time64_to_tm()
To cover calculation of the time and wday in the rtc kunit test also check tm_hour, tm_min, tm_sec and tm_wday of the rtc_time calculated by rtc_time64_to_tm(). There are no surprises, the two tests making use of rtc_time64_to_tm_test_date_range() continue to succeed. Signed-off-by: Uwe Kleine-König <[email protected]> Signed-off-by: Alexandre Mergnat <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]>
1 parent 4635192 commit da62b49

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

drivers/rtc/lib_test.c

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,10 @@
66
/*
77
* Advance a date by one day.
88
*/
9-
static void advance_date(int *year, int *month, int *mday, int *yday)
9+
static void advance_date(int *year, int *month, int *mday, int *yday, int *wday)
1010
{
11+
*wday = (*wday + 1) % 7;
12+
1113
if (*mday != rtc_month_days(*month - 1, *year)) {
1214
++*mday;
1315
++*yday;
@@ -43,23 +45,29 @@ static void rtc_time64_to_tm_test_date_range(struct kunit *test, int years)
4345
int month = 1;
4446
int mday = 1;
4547
int yday = 1;
48+
int wday = 4; /* Jan 1st 1970 was a Thursday */
4649

4750
struct rtc_time result;
4851
time64_t secs;
52+
const time64_t sec_offset = ((1 * 60) + 2) * 60 + 3;
4953

5054
for (secs = 0; secs <= total_secs; secs += 86400) {
5155

52-
rtc_time64_to_tm(secs, &result);
56+
rtc_time64_to_tm(secs + sec_offset, &result);
5357

54-
#define FAIL_MSG "%d/%02d/%02d (%2d) : %lld", \
55-
year, month, mday, yday, secs
58+
#define FAIL_MSG "%d/%02d/%02d (%2d, %d) : %lld", \
59+
year, month, mday, yday, wday, secs + sec_offset
5660

5761
KUNIT_ASSERT_EQ_MSG(test, year - 1900, result.tm_year, FAIL_MSG);
5862
KUNIT_ASSERT_EQ_MSG(test, month - 1, result.tm_mon, FAIL_MSG);
5963
KUNIT_ASSERT_EQ_MSG(test, mday, result.tm_mday, FAIL_MSG);
6064
KUNIT_ASSERT_EQ_MSG(test, yday, result.tm_yday, FAIL_MSG);
65+
KUNIT_ASSERT_EQ_MSG(test, 1, result.tm_hour, FAIL_MSG);
66+
KUNIT_ASSERT_EQ_MSG(test, 2, result.tm_min, FAIL_MSG);
67+
KUNIT_ASSERT_EQ_MSG(test, 3, result.tm_sec, FAIL_MSG);
68+
KUNIT_ASSERT_EQ_MSG(test, wday, result.tm_wday, FAIL_MSG);
6169

62-
advance_date(&year, &month, &mday, &yday);
70+
advance_date(&year, &month, &mday, &yday, &wday);
6371
}
6472
}
6573

0 commit comments

Comments
 (0)