Skip to content

Commit ef91f79

Browse files
Yang Yingliangdavem330
authored andcommitted
net: gemini: Use devm_platform_get_and_ioremap_resource()
Use devm_platform_get_and_ioremap_resource() to simplify code. Signed-off-by: Yang Yingliang <[email protected]> Reviewed-by: Linus Walleij <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 4fb473f commit ef91f79

File tree

1 file changed

+9
-25
lines changed

1 file changed

+9
-25
lines changed

drivers/net/ethernet/cortina/gemini.c

Lines changed: 9 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -2356,8 +2356,6 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev)
23562356
struct device *dev = &pdev->dev;
23572357
struct gemini_ethernet *geth;
23582358
struct net_device *netdev;
2359-
struct resource *gmacres;
2360-
struct resource *dmares;
23612359
struct device *parent;
23622360
unsigned int id;
23632361
int irq;
@@ -2390,24 +2388,18 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev)
23902388
port->msg_enable = netif_msg_init(debug, DEFAULT_MSG_ENABLE);
23912389

23922390
/* DMA memory */
2393-
dmares = platform_get_resource(pdev, IORESOURCE_MEM, 0);
2394-
if (!dmares) {
2395-
dev_err(dev, "no DMA resource\n");
2396-
return -ENODEV;
2397-
}
2398-
port->dma_base = devm_ioremap_resource(dev, dmares);
2399-
if (IS_ERR(port->dma_base))
2391+
port->dma_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
2392+
if (IS_ERR(port->dma_base)) {
2393+
dev_err(dev, "get DMA address failed\n");
24002394
return PTR_ERR(port->dma_base);
2395+
}
24012396

24022397
/* GMAC config memory */
2403-
gmacres = platform_get_resource(pdev, IORESOURCE_MEM, 1);
2404-
if (!gmacres) {
2405-
dev_err(dev, "no GMAC resource\n");
2406-
return -ENODEV;
2407-
}
2408-
port->gmac_base = devm_ioremap_resource(dev, gmacres);
2409-
if (IS_ERR(port->gmac_base))
2398+
port->gmac_base = devm_platform_get_and_ioremap_resource(pdev, 1, NULL);
2399+
if (IS_ERR(port->gmac_base)) {
2400+
dev_err(dev, "get GMAC address failed\n");
24102401
return PTR_ERR(port->gmac_base);
2402+
}
24112403

24122404
/* Interrupt */
24132405
irq = platform_get_irq(pdev, 0);
@@ -2502,10 +2494,6 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev)
25022494
if (ret)
25032495
goto unprepare;
25042496

2505-
netdev_info(netdev,
2506-
"irq %d, DMA @ 0x%pap, GMAC @ 0x%pap\n",
2507-
port->irq, &dmares->start,
2508-
&gmacres->start);
25092497
return 0;
25102498

25112499
unprepare:
@@ -2544,17 +2532,13 @@ static int gemini_ethernet_probe(struct platform_device *pdev)
25442532
struct device *dev = &pdev->dev;
25452533
struct gemini_ethernet *geth;
25462534
unsigned int retry = 5;
2547-
struct resource *res;
25482535
u32 val;
25492536

25502537
/* Global registers */
25512538
geth = devm_kzalloc(dev, sizeof(*geth), GFP_KERNEL);
25522539
if (!geth)
25532540
return -ENOMEM;
2554-
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
2555-
if (!res)
2556-
return -ENODEV;
2557-
geth->base = devm_ioremap_resource(dev, res);
2541+
geth->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
25582542
if (IS_ERR(geth->base))
25592543
return PTR_ERR(geth->base);
25602544
geth->dev = dev;

0 commit comments

Comments
 (0)