Skip to content

Commit f04e2ad

Browse files
visitorckwanakryiko
authored andcommitted
bpftool: Fix undefined behavior in qsort(NULL, 0, ...)
When netfilter has no entry to display, qsort is called with qsort(NULL, 0, ...). This results in undefined behavior, as UBSan reports: net.c:827:2: runtime error: null pointer passed as argument 1, which is declared to never be null Although the C standard does not explicitly state whether calling qsort with a NULL pointer when the size is 0 constitutes undefined behavior, Section 7.1.4 of the C standard (Use of library functions) mentions: "Each of the following statements applies unless explicitly stated otherwise in the detailed descriptions that follow: If an argument to a function has an invalid value (such as a value outside the domain of the function, or a pointer outside the address space of the program, or a null pointer, or a pointer to non-modifiable storage when the corresponding parameter is not const-qualified) or a type (after promotion) not expected by a function with variable number of arguments, the behavior is undefined." To avoid this, add an early return when nf_link_info is NULL to prevent calling qsort with a NULL pointer. Signed-off-by: Kuan-Wei Chiu <[email protected]> Signed-off-by: Andrii Nakryiko <[email protected]> Reviewed-by: Quentin Monnet <[email protected]> Link: https://lore.kernel.org/bpf/[email protected]
1 parent 8c8b475 commit f04e2ad

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

tools/bpf/bpftool/net.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -880,6 +880,9 @@ static void show_link_netfilter(void)
880880
nf_link_count++;
881881
}
882882

883+
if (!nf_link_info)
884+
return;
885+
883886
qsort(nf_link_info, nf_link_count, sizeof(*nf_link_info), netfilter_link_compar);
884887

885888
for (id = 0; id < nf_link_count; id++) {

0 commit comments

Comments
 (0)