Skip to content

Commit f11de86

Browse files
committed
Merge tag 'drm-intel-next-fixes-2022-03-17' of git://anongit.freedesktop.org/drm/drm-intel into drm-next
- Do not re-enable PSR after it was marked as not reliable (Jose) - Add missing boundary check in vm_access to avoid out-of-bounds access (Mastan) - Naming fix for HPD short pulse handling for eDP (Jose) Signed-off-by: Dave Airlie <[email protected]> From: Joonas Lahtinen <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
2 parents f6d790e + 278da06 commit f11de86

File tree

5 files changed

+10
-6
lines changed

5 files changed

+10
-6
lines changed

drivers/gpu/drm/i915/display/intel_dp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4863,7 +4863,7 @@ intel_dp_hpd_pulse(struct intel_digital_port *dig_port, bool long_hpd)
48634863
struct intel_dp *intel_dp = &dig_port->dp;
48644864

48654865
if (dig_port->base.type == INTEL_OUTPUT_EDP &&
4866-
(long_hpd || !intel_pps_have_power(intel_dp))) {
4866+
(long_hpd || !intel_pps_have_panel_power_or_vdd(intel_dp))) {
48674867
/*
48684868
* vdd off can generate a long/short pulse on eDP which
48694869
* would require vdd on to handle it, and thus we

drivers/gpu/drm/i915/display/intel_pps.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1075,14 +1075,14 @@ static void intel_pps_vdd_sanitize(struct intel_dp *intel_dp)
10751075
edp_panel_vdd_schedule_off(intel_dp);
10761076
}
10771077

1078-
bool intel_pps_have_power(struct intel_dp *intel_dp)
1078+
bool intel_pps_have_panel_power_or_vdd(struct intel_dp *intel_dp)
10791079
{
10801080
intel_wakeref_t wakeref;
10811081
bool have_power = false;
10821082

10831083
with_intel_pps_lock(intel_dp, wakeref) {
1084-
have_power = edp_have_panel_power(intel_dp) &&
1085-
edp_have_panel_vdd(intel_dp);
1084+
have_power = edp_have_panel_power(intel_dp) ||
1085+
edp_have_panel_vdd(intel_dp);
10861086
}
10871087

10881088
return have_power;

drivers/gpu/drm/i915/display/intel_pps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ void intel_pps_vdd_on(struct intel_dp *intel_dp);
3737
void intel_pps_on(struct intel_dp *intel_dp);
3838
void intel_pps_off(struct intel_dp *intel_dp);
3939
void intel_pps_vdd_off_sync(struct intel_dp *intel_dp);
40-
bool intel_pps_have_power(struct intel_dp *intel_dp);
40+
bool intel_pps_have_panel_power_or_vdd(struct intel_dp *intel_dp);
4141
void intel_pps_wait_power_cycle(struct intel_dp *intel_dp);
4242

4343
void intel_pps_init(struct intel_dp *intel_dp);

drivers/gpu/drm/i915/display/intel_psr.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1837,6 +1837,9 @@ static void _intel_psr_post_plane_update(const struct intel_atomic_state *state,
18371837

18381838
mutex_lock(&psr->lock);
18391839

1840+
if (psr->sink_not_reliable)
1841+
goto exit;
1842+
18401843
drm_WARN_ON(&dev_priv->drm, psr->enabled && !crtc_state->active_planes);
18411844

18421845
/* Only enable if there is active planes */
@@ -1847,6 +1850,7 @@ static void _intel_psr_post_plane_update(const struct intel_atomic_state *state,
18471850
if (crtc_state->crc_enabled && psr->enabled)
18481851
psr_force_hw_tracking_exit(intel_dp);
18491852

1853+
exit:
18501854
mutex_unlock(&psr->lock);
18511855
}
18521856
}

drivers/gpu/drm/i915/gem/i915_gem_mman.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,7 @@ vm_access(struct vm_area_struct *area, unsigned long addr,
455455
return -EACCES;
456456

457457
addr -= area->vm_start;
458-
if (addr >= obj->base.size)
458+
if (range_overflows_t(u64, addr, len, obj->base.size))
459459
return -EINVAL;
460460

461461
i915_gem_ww_ctx_init(&ww, true);

0 commit comments

Comments
 (0)