Skip to content

Commit f79d7a9

Browse files
Michael Chankuba-moo
authored andcommitted
bnxt_en: Don't call ULP_STOP/ULP_START during L2 reset
There is no need to call ULP_STOP and ULP_START before and after the L2 reset in bnxt_reset_task(). This L2 reset is done after detecting TX timeout, RX ring errors, or VF config changes. The L2 reset does not affect RoCE since the firmware is not reset and the backing store is left alone. Reviewed-by: Andy Gospodarek <[email protected]> Reviewed-by: Pavan Chebbi <[email protected]> Signed-off-by: Michael Chan <[email protected]> Reviewed-by: Simon Horman <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 895621f commit f79d7a9

File tree

1 file changed

+2
-11
lines changed
  • drivers/net/ethernet/broadcom/bnxt

1 file changed

+2
-11
lines changed

drivers/net/ethernet/broadcom/bnxt/bnxt.c

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13089,17 +13089,8 @@ static void bnxt_reset_task(struct bnxt *bp, bool silent)
1308913089
if (!silent)
1309013090
bnxt_dbg_dump_states(bp);
1309113091
if (netif_running(bp->dev)) {
13092-
int rc;
13093-
13094-
if (silent) {
13095-
bnxt_close_nic(bp, false, false);
13096-
bnxt_open_nic(bp, false, false);
13097-
} else {
13098-
bnxt_ulp_stop(bp);
13099-
bnxt_close_nic(bp, true, false);
13100-
rc = bnxt_open_nic(bp, true, false);
13101-
bnxt_ulp_start(bp, rc);
13102-
}
13092+
bnxt_close_nic(bp, !silent, false);
13093+
bnxt_open_nic(bp, !silent, false);
1310313094
}
1310413095
}
1310513096

0 commit comments

Comments
 (0)