Skip to content

Commit 3ff32ef

Browse files
oohalmpe
authored andcommitted
powerpc/eeh: Remove PHB check in probe
This check for a missing PHB has existing in various forms since the initial PPC64 port was upstreamed in 2002. The idea seems to be that we need to guard against creating pci-specific data structures for the non-pci children of a PCI device tree node (e.g. USB devices). However, we only create pci_dn structures for DT nodes that correspond to PCI devices so there's not much point in doing this check in the eeh_probe path. Reviewed-by: Sam Bobroff <[email protected]> Signed-off-by: Oliver O'Halloran <[email protected]> Signed-off-by: Michael Ellerman <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent a4b4f61 commit 3ff32ef

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

arch/powerpc/kernel/eeh.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1120,7 +1120,6 @@ core_initcall_sync(eeh_init);
11201120
*/
11211121
void eeh_add_device_early(struct pci_dn *pdn)
11221122
{
1123-
struct pci_controller *phb = pdn ? pdn->phb : NULL;
11241123
struct eeh_dev *edev = pdn_to_eeh_dev(pdn);
11251124

11261125
if (!edev)
@@ -1129,11 +1128,6 @@ void eeh_add_device_early(struct pci_dn *pdn)
11291128
if (!eeh_has_flag(EEH_PROBE_MODE_DEVTREE))
11301129
return;
11311130

1132-
/* USB Bus children of PCI devices will not have BUID's */
1133-
if (NULL == phb ||
1134-
(eeh_has_flag(EEH_PROBE_MODE_DEVTREE) && 0 == phb->buid))
1135-
return;
1136-
11371131
eeh_ops->probe(pdn, NULL);
11381132
}
11391133

0 commit comments

Comments
 (0)