Skip to content

Commit e859536

Browse files
geertudavem330
authored andcommitted
chelsio/chtls: Re-add dependencies on CHELSIO_T4 to fix modular CHELSIO_T4
As CHELSIO_INLINE_CRYPTO is bool, and CHELSIO_T4 is tristate, the dependency of CHELSIO_INLINE_CRYPTO on CHELSIO_T4 is not sufficient to protect CRYPTO_DEV_CHELSIO_TLS and CHELSIO_IPSEC_INLINE. The latter two are also tristate, hence if CHELSIO_T4=n, they cannot be builtin, as that would lead to link failures like: drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_main.c:259: undefined reference to `cxgb4_port_viid' and drivers/net/ethernet/chelsio/inline_crypto/ch_ipsec/chcr_ipsec.c:752: undefined reference to `cxgb4_reclaim_completed_tx' Fix this by re-adding dependencies on CHELSIO_T4 to tristate symbols. The dependency of CHELSIO_INLINE_CRYPTO on CHELSIO_T4 is kept to avoid asking the user. Fixes: 6bd860a ("chelsio/chtls: CHELSIO_INLINE_CRYPTO should depend on CHELSIO_T4") Reported-by: kernel test robot <[email protected]> Signed-off-by: Geert Uytterhoeven <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent b18af88 commit e859536

File tree

1 file changed

+2
-0
lines changed
  • drivers/net/ethernet/chelsio/inline_crypto

1 file changed

+2
-0
lines changed

drivers/net/ethernet/chelsio/inline_crypto/Kconfig

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ if CHELSIO_INLINE_CRYPTO
1515

1616
config CRYPTO_DEV_CHELSIO_TLS
1717
tristate "Chelsio Crypto Inline TLS Driver"
18+
depends on CHELSIO_T4
1819
depends on TLS_TOE
1920
help
2021
Support Chelsio Inline TLS with Chelsio crypto accelerator.
@@ -25,6 +26,7 @@ config CRYPTO_DEV_CHELSIO_TLS
2526

2627
config CHELSIO_IPSEC_INLINE
2728
tristate "Chelsio IPSec XFRM Tx crypto offload"
29+
depends on CHELSIO_T4
2830
depends on XFRM_OFFLOAD
2931
depends on INET_ESP_OFFLOAD || INET6_ESP_OFFLOAD
3032
help

0 commit comments

Comments
 (0)