Skip to content

Commit ff1f7c1

Browse files
kuba-moodavem330
authored andcommitted
netdevsim: add pause frame stats
Add minimal ethtool interface for testing ethtool pause stats. v2: add missing static on nsim_ethtool_ops Signed-off-by: Jakub Kicinski <[email protected]> Reviewed-by: Saeed Mahameed <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 8c00bd9 commit ff1f7c1

File tree

4 files changed

+77
-1
lines changed

4 files changed

+77
-1
lines changed

drivers/net/netdevsim/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
obj-$(CONFIG_NETDEVSIM) += netdevsim.o
44

55
netdevsim-objs := \
6-
netdev.o dev.o fib.o bus.o health.o udp_tunnels.o
6+
netdev.o dev.o ethtool.o fib.o bus.o health.o udp_tunnels.o
77

88
ifeq ($(CONFIG_BPF_SYSCALL),y)
99
netdevsim-objs += \

drivers/net/netdevsim/ethtool.c

Lines changed: 64 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
// SPDX-License-Identifier: GPL-2.0
2+
// Copyright (c) 2020 Facebook
3+
4+
#include <linux/debugfs.h>
5+
#include <linux/ethtool.h>
6+
#include <linux/random.h>
7+
8+
#include "netdevsim.h"
9+
10+
static void
11+
nsim_get_pause_stats(struct net_device *dev,
12+
struct ethtool_pause_stats *pause_stats)
13+
{
14+
struct netdevsim *ns = netdev_priv(dev);
15+
16+
if (ns->ethtool.report_stats_rx)
17+
pause_stats->rx_pause_frames = 1;
18+
if (ns->ethtool.report_stats_tx)
19+
pause_stats->tx_pause_frames = 2;
20+
}
21+
22+
static void
23+
nsim_get_pauseparam(struct net_device *dev, struct ethtool_pauseparam *pause)
24+
{
25+
struct netdevsim *ns = netdev_priv(dev);
26+
27+
pause->autoneg = 0; /* We don't support ksettings, so can't pretend */
28+
pause->rx_pause = ns->ethtool.rx;
29+
pause->tx_pause = ns->ethtool.tx;
30+
}
31+
32+
static int
33+
nsim_set_pauseparam(struct net_device *dev, struct ethtool_pauseparam *pause)
34+
{
35+
struct netdevsim *ns = netdev_priv(dev);
36+
37+
if (pause->autoneg)
38+
return -EINVAL;
39+
40+
ns->ethtool.rx = pause->rx_pause;
41+
ns->ethtool.tx = pause->tx_pause;
42+
return 0;
43+
}
44+
45+
static const struct ethtool_ops nsim_ethtool_ops = {
46+
.get_pause_stats = nsim_get_pause_stats,
47+
.get_pauseparam = nsim_get_pauseparam,
48+
.set_pauseparam = nsim_set_pauseparam,
49+
};
50+
51+
void nsim_ethtool_init(struct netdevsim *ns)
52+
{
53+
struct dentry *ethtool, *dir;
54+
55+
ns->netdev->ethtool_ops = &nsim_ethtool_ops;
56+
57+
ethtool = debugfs_create_dir("ethtool", ns->nsim_dev->ddir);
58+
59+
dir = debugfs_create_dir("pause", ethtool);
60+
debugfs_create_bool("report_stats_rx", 0600, dir,
61+
&ns->ethtool.report_stats_rx);
62+
debugfs_create_bool("report_stats_tx", 0600, dir,
63+
&ns->ethtool.report_stats_tx);
64+
}

drivers/net/netdevsim/netdev.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -301,6 +301,7 @@ nsim_create(struct nsim_dev *nsim_dev, struct nsim_dev_port *nsim_dev_port)
301301
ns->nsim_bus_dev = nsim_dev->nsim_bus_dev;
302302
SET_NETDEV_DEV(dev, &ns->nsim_bus_dev->dev);
303303
dev->netdev_ops = &nsim_netdev_ops;
304+
nsim_ethtool_init(ns);
304305

305306
err = nsim_udp_tunnels_info_create(nsim_dev, dev);
306307
if (err)

drivers/net/netdevsim/netdevsim.h

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,13 @@ struct nsim_ipsec {
5050
u32 ok;
5151
};
5252

53+
struct nsim_ethtool {
54+
bool rx;
55+
bool tx;
56+
bool report_stats_rx;
57+
bool report_stats_tx;
58+
};
59+
5360
struct netdevsim {
5461
struct net_device *netdev;
5562
struct nsim_dev *nsim_dev;
@@ -80,12 +87,16 @@ struct netdevsim {
8087
u32 ports[2][NSIM_UDP_TUNNEL_N_PORTS];
8188
struct debugfs_u32_array dfs_ports[2];
8289
} udp_ports;
90+
91+
struct nsim_ethtool ethtool;
8392
};
8493

8594
struct netdevsim *
8695
nsim_create(struct nsim_dev *nsim_dev, struct nsim_dev_port *nsim_dev_port);
8796
void nsim_destroy(struct netdevsim *ns);
8897

98+
void nsim_ethtool_init(struct netdevsim *ns);
99+
89100
void nsim_udp_tunnels_debugfs_create(struct nsim_dev *nsim_dev);
90101
int nsim_udp_tunnels_info_create(struct nsim_dev *nsim_dev,
91102
struct net_device *dev);

0 commit comments

Comments
 (0)