Skip to content

Commit 1a8dfa0

Browse files
committed
Move to build:gradle:3.5.4 (adds support for API 30), fix some tests
1 parent c1cc116 commit 1a8dfa0

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

pythonforandroid/bootstraps/common/build/templates/build.tmpl.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ buildscript {
55
jcenter()
66
}
77
dependencies {
8-
classpath 'com.android.tools.build:gradle:3.5.2'
8+
classpath 'com.android.tools.build:gradle:3.5.4'
99
}
1010
}
1111

tests/test_build.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import jinja2
55

66
from pythonforandroid.build import run_pymodules_install
7+
from pythonforandroid.archs import ArchARMv7_a, ArchAarch_64
78

89

910
class TestBuildBasic(unittest.TestCase):
@@ -14,6 +15,7 @@ def test_run_pymodules_install_optional_project_dir(self):
1415
`project_dir` optional parameter is None, refs #1898
1516
"""
1617
ctx = mock.Mock()
18+
ctx.archs = [ArchARMv7_a(ctx), ArchAarch_64(ctx)]
1719
modules = []
1820
project_dir = None
1921
with mock.patch('pythonforandroid.build.info') as m_info:

tests/test_toolchain.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,8 @@ def test_create(self):
6262
'--dist-name=test_toolchain',
6363
'--activity-class-name=abc.myapp.android.CustomPythonActivity',
6464
'--service-class-name=xyz.myapp.android.CustomPythonService',
65+
'--arch=arm64-v8a',
66+
'--arch=armeabi-v7a'
6567
]
6668
with patch_sys_argv(argv), mock.patch(
6769
'pythonforandroid.build.get_available_apis'
@@ -116,7 +118,7 @@ def test_create_no_sdk_dir(self):
116118
"""
117119
The `--sdk-dir` is mandatory to `create` a distribution.
118120
"""
119-
argv = ['toolchain.py', 'create']
121+
argv = ['toolchain.py', 'create', '--arch=arm64-v8a', '--arch=armeabi-v7a']
120122
with patch_sys_argv(argv), pytest.raises(
121123
BuildInterruptingException
122124
) as ex_info:

0 commit comments

Comments
 (0)