Skip to content

Commit 1ce7d8c

Browse files
committed
🚀 Make test app on_device_unit_tests the default...
for our CI providers and `rebuild_updated_recipes.py` because we recently removed the old test app that we made use of.
1 parent 52162ef commit 1ce7d8c

File tree

3 files changed

+10
-17
lines changed

3 files changed

+10
-17
lines changed

.github/workflows/push.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
make docker/run/make/with-artifact/testapps/python3/${{ matrix.build-arch }}
6161
- uses: actions/upload-artifact@v1
6262
with:
63-
name: bdisttest_python3_sqlite_openssl_googlendk__${{ matrix.build-arch }}-debug-1.1.apk
63+
name: bdist_test_app_unittests__${{ matrix.build-arch }}-debug-1.1.apk
6464
path: apks
6565

6666
rebuild_updated_recipes:

Makefile

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -36,19 +36,19 @@ rebuild_updated_recipes: virtualenv
3636
$(PYTHON) ci/rebuild_updated_recipes.py
3737

3838
testapps/python2/armeabi-v7a: virtualenv
39-
. $(ACTIVATE) && cd testapps/ && \
40-
python setup_testapp_python2_sqlite_openssl.py apk --sdk-dir $(ANDROID_SDK_HOME) --ndk-dir $(ANDROID_NDK_HOME) \
39+
. $(ACTIVATE) && cd testapps/on_device_unit_tests/ && \
40+
python setup_test_app.py apk --sdk-dir $(ANDROID_SDK_HOME) --ndk-dir $(ANDROID_NDK_HOME) \
4141
--requirements sdl2,pyjnius,kivy,python2,openssl,requests,sqlite3,setuptools
4242

4343
testapps/python3/arm64-v8a: virtualenv
44-
. $(ACTIVATE) && cd testapps/ && \
45-
python setup_testapp_python3_sqlite_openssl.py apk --sdk-dir $(ANDROID_SDK_HOME) --ndk-dir $(ANDROID_NDK_HOME) \
44+
. $(ACTIVATE) && cd testapps/on_device_unit_tests/ && \
45+
python setup_test_app.py apk --sdk-dir $(ANDROID_SDK_HOME) --ndk-dir $(ANDROID_NDK_HOME) \
4646
--requirements libffi,sdl2,pyjnius,kivy,python3,openssl,requests,sqlite3,setuptools,numpy \
4747
--arch=arm64-v8a
4848

4949
testapps/python3/armeabi-v7a: virtualenv
50-
. $(ACTIVATE) && cd testapps/ && \
51-
python setup_testapp_python3_sqlite_openssl.py apk --sdk-dir $(ANDROID_SDK_HOME) --ndk-dir $(ANDROID_NDK_HOME) \
50+
. $(ACTIVATE) && cd testapps/on_device_unit_tests/ && \
51+
python setup_test_app.py apk --sdk-dir $(ANDROID_SDK_HOME) --ndk-dir $(ANDROID_NDK_HOME) \
5252
--arch=armeabi-v7a
5353

5454
clean:
@@ -77,14 +77,9 @@ docker/run/make/%: docker/build
7777
docker run --rm --env-file=.env $(DOCKER_IMAGE) make $*
7878

7979
docker/run/make/with-artifact/%: docker/build
80-
ifeq (,$(findstring python3,$($*)))
81-
$(eval $@_APP_NAME := bdisttest_python3_sqlite_openssl_googlendk)
82-
else
83-
$(eval $@_APP_NAME := bdisttest_python2_sqlite_openssl)
84-
endif
8580
$(eval $@_APP_ARCH := $(shell basename $*))
8681
docker run --name p4a-latest --env-file=.env $(DOCKER_IMAGE) make $*
87-
docker cp p4a-latest:/home/user/app/testapps/$($@_APP_NAME)__$($@_APP_ARCH)-debug-1.1-.apk ./apks
82+
docker cp p4a-latest:/home/user/app/testapps/on_device_unit_tests/bdist_test_app_unittests__$($@_APP_ARCH)-debug-1.1-.apk ./apks
8883
docker rm -fv p4a-latest
8984

9085
docker/run/shell: docker/build

ci/rebuild_updated_recipes.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,15 +55,13 @@ def build(target_python, requirements):
5555
"""
5656
if not requirements:
5757
return
58-
testapp = 'setup_testapp_python2.py'
58+
testapp = 'setup_test_app.py'
5959
android_sdk_home = os.environ['ANDROID_SDK_HOME']
6060
android_ndk_home = os.environ['ANDROID_NDK_HOME']
61-
if target_python == TargetPython.python3:
62-
testapp = 'setup_testapp_python3_sqlite_openssl.py'
6361
requirements.add(target_python.name)
6462
requirements = ','.join(requirements)
6563
logger.info('requirements: {}'.format(requirements))
66-
with current_directory('testapps/'):
64+
with current_directory('testapps/on_device_unit_tests/'):
6765
# iterates to stream the output
6866
for line in sh.python(
6967
testapp, 'apk', '--sdk-dir', android_sdk_home,

0 commit comments

Comments
 (0)