Skip to content

Commit 2d98daa

Browse files
authored
Merge pull request #1452 from dbrnz/wrong_cpp_env_flags
C++ recipe didn't set all instances of `ctx.ndk_dir` in format string
2 parents 0fcf195 + ba280fb commit 2d98daa

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

pythonforandroid/recipe.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -548,8 +548,8 @@ def clean_build(self, arch=None):
548548
if exists(base_dir):
549549
dirs.append(base_dir)
550550
if not dirs:
551-
warning(('Attempted to clean build for {} but found no existing '
552-
'build dirs').format(self.name))
551+
warning('Attempted to clean build for {} but found no existing '
552+
'build dirs'.format(self.name))
553553

554554
for directory in dirs:
555555
if exists(directory):
@@ -924,11 +924,11 @@ def get_recipe_env(self, arch):
924924
env['CFLAGS'] += (
925925
" -I{ctx.ndk_dir}/platforms/android-{ctx.android_api}/arch-{arch_noeabi}/usr/include" +
926926
" -I{ctx.ndk_dir}/sources/cxx-stl/gnu-libstdc++/{ctx.toolchain_version}/include" +
927-
" -I{ctx.ndk_dir}/sources/cxx-stl/gnu-libstdc++/{ctx.toolchain_version}/libs/{arch.arch}/include".format(**keys))
927+
" -I{ctx.ndk_dir}/sources/cxx-stl/gnu-libstdc++/{ctx.toolchain_version}/libs/{arch.arch}/include").format(**keys)
928928
env['CXXFLAGS'] = env['CFLAGS'] + ' -frtti -fexceptions'
929929
env['LDFLAGS'] += (
930930
" -L{ctx.ndk_dir}/sources/cxx-stl/gnu-libstdc++/{ctx.toolchain_version}/libs/{arch.arch}" +
931-
" -lgnustl_shared".format(**keys))
931+
" -lgnustl_shared").format(**keys)
932932

933933
return env
934934

0 commit comments

Comments
 (0)