Skip to content

Commit 6b6e1a6

Browse files
committed
🏗️ Make test app on_device_unit_tests the default...
for our CI providers and `rebuild_updated_recipes.py` because we recently removed the old test app that we made use of.
1 parent 71eafe3 commit 6b6e1a6

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

.github/workflows/push.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ jobs:
6060
make docker/run/make/with-artifact/testapps/${{ matrix.build-arch }}
6161
- uses: actions/upload-artifact@v1
6262
with:
63-
name: bdisttest_python3_sqlite_openssl_googlendk__${{ matrix.build-arch }}-debug-1.1.apk
63+
name: bdist_test_app_unittests__${{ matrix.build-arch }}-debug-1.1.apk
6464
path: apks
6565

6666
rebuild_updated_recipes:

Makefile

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,14 @@ rebuild_updated_recipes: virtualenv
3636
$(PYTHON) ci/rebuild_updated_recipes.py
3737

3838
testapps/arm64-v8a: virtualenv
39-
. $(ACTIVATE) && cd testapps/ && \
40-
python setup_testapp_python3_sqlite_openssl.py apk --sdk-dir $(ANDROID_SDK_HOME) --ndk-dir $(ANDROID_NDK_HOME) \
39+
. $(ACTIVATE) && cd testapps/on_device_unit_tests/ && \
40+
python setup_test_app.py apk --sdk-dir $(ANDROID_SDK_HOME) --ndk-dir $(ANDROID_NDK_HOME) \
4141
--requirements libffi,sdl2,pyjnius,kivy,python3,openssl,requests,sqlite3,setuptools,numpy \
4242
--arch=arm64-v8a
4343

4444
testapps/armeabi-v7a: virtualenv
45-
. $(ACTIVATE) && cd testapps/ && \
46-
python setup_testapp_python3_sqlite_openssl.py apk --sdk-dir $(ANDROID_SDK_HOME) --ndk-dir $(ANDROID_NDK_HOME) \
45+
. $(ACTIVATE) && cd testapps/on_device_unit_tests/ && \
46+
python setup_test_app.py apk --sdk-dir $(ANDROID_SDK_HOME) --ndk-dir $(ANDROID_NDK_HOME) \
4747
--arch=armeabi-v7a
4848

4949
clean:
@@ -72,10 +72,9 @@ docker/run/make/%: docker/build
7272
docker run --rm --env-file=.env $(DOCKER_IMAGE) make $*
7373

7474
docker/run/make/with-artifact/%: docker/build
75-
$(eval $@_APP_NAME := bdisttest_python3_sqlite_openssl_googlendk)
7675
$(eval $@_APP_ARCH := $(shell basename $*))
7776
docker run --name p4a-latest --env-file=.env $(DOCKER_IMAGE) make $*
78-
docker cp p4a-latest:/home/user/app/testapps/$($@_APP_NAME)__$($@_APP_ARCH)-debug-1.1-.apk ./apks
77+
docker cp p4a-latest:/home/user/app/testapps/on_device_unit_tests/bdist_test_app_unittests__$($@_APP_ARCH)-debug-1.1-.apk ./apks
7978
docker rm -fv p4a-latest
8079

8180
docker/run/shell: docker/build

ci/rebuild_updated_recipes.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,13 @@ def build(target_python, requirements):
5252
"""
5353
if not requirements:
5454
return
55-
testapp = 'setup_testapp_python3_sqlite_openssl.py'
55+
testapp = 'setup_test_app.py'
5656
android_sdk_home = os.environ['ANDROID_SDK_HOME']
5757
android_ndk_home = os.environ['ANDROID_NDK_HOME']
5858
requirements.add(target_python.name)
5959
requirements = ','.join(requirements)
6060
logger.info('requirements: {}'.format(requirements))
61-
with current_directory('testapps/'):
61+
with current_directory('testapps/on_device_unit_tests/'):
6262
# iterates to stream the output
6363
for line in sh.python(
6464
testapp, 'apk', '--sdk-dir', android_sdk_home,

0 commit comments

Comments
 (0)