Skip to content

Commit 846d80d

Browse files
authored
Upload artifacts produced from every build platform, not only ubuntu-latest (#2588)
1 parent a2fb480 commit 846d80d

File tree

1 file changed

+39
-7
lines changed

1 file changed

+39
-7
lines changed

.github/workflows/push.yml

Lines changed: 39 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@ name: Unit tests & build apps
22

33
on: ['push', 'pull_request']
44

5+
env:
6+
APK_ARTIFACT_FILENAME: bdist_unit_tests_app-debug-1.1-.apk
7+
AAB_ARTIFACT_FILENAME: bdist_unit_tests_app-release-1.1-.aab
8+
59
jobs:
610

711
flake8:
@@ -48,9 +52,13 @@ jobs:
4852
flag-name: run-${{ matrix.os }}-${{ matrix.python-version }}
4953

5054
ubuntu_build_apk:
51-
name: Unit test apk [ ubuntu-latest ]
55+
name: Unit test apk [ ${{ matrix.runs_on }} ]
5256
needs: [flake8]
53-
runs-on: ubuntu-latest
57+
runs-on: ${{ matrix.runs_on }}
58+
strategy:
59+
matrix:
60+
include:
61+
- runs_on: ubuntu-latest
5462
steps:
5563
- name: Checkout python-for-android
5664
uses: actions/checkout@v2
@@ -70,9 +78,12 @@ jobs:
7078
run: |
7179
mkdir -p apks
7280
make docker/run/make/with-artifact/apk/testapps-with-numpy
81+
- name: Rename artifact to include the build platform name
82+
run: |
83+
mv apks/${{ env.APK_ARTIFACT_FILENAME }} apks/${{ matrix.runs_on }}-${{ env.APK_ARTIFACT_FILENAME }}
7384
- uses: actions/upload-artifact@v1
7485
with:
75-
name: bdist_unit_tests_app-debug-1.1-.apk
86+
name: ${{ matrix.runs_on }}-${{ env.APK_ARTIFACT_FILENAME }}
7687
path: apks
7788

7889
macos_build_apk:
@@ -107,11 +118,22 @@ jobs:
107118
source ci/osx_ci.sh
108119
arm64_set_path_and_python_version 3.9.7
109120
make testapps-with-numpy
121+
- name: Rename artifact to include the build platform name
122+
run: |
123+
mv testapps/on_device_unit_tests/${{ env.APK_ARTIFACT_FILENAME }} ${{ matrix.runs_on }}-${{ env.APK_ARTIFACT_FILENAME }}
124+
- uses: actions/upload-artifact@v1
125+
with:
126+
name: ${{ matrix.runs_on }}-${{ env.APK_ARTIFACT_FILENAME }}
127+
path: ${{ matrix.runs_on }}-${{ env.APK_ARTIFACT_FILENAME }}
110128

111129
ubuntu_build_aab:
112-
name: Unit test aab [ ubuntu-latest ]
130+
name: Unit test aab [ ${{ matrix.runs_on }} ]
113131
needs: [flake8]
114-
runs-on: ubuntu-latest
132+
runs-on: ${{ matrix.runs_on }}
133+
strategy:
134+
matrix:
135+
include:
136+
- runs_on: ubuntu-latest
115137
steps:
116138
- name: Checkout python-for-android
117139
uses: actions/checkout@v2
@@ -131,9 +153,12 @@ jobs:
131153
run: |
132154
mkdir -p aabs
133155
make docker/run/make/with-artifact/aab/testapps-with-numpy-aab
156+
- name: Rename artifact to include the build platform name
157+
run: |
158+
mv aabs/${{ env.AAB_ARTIFACT_FILENAME }} aabs/${{ matrix.runs_on }}-${{ env.AAB_ARTIFACT_FILENAME }}
134159
- uses: actions/upload-artifact@v1
135160
with:
136-
name: bdist_unit_tests_app-release-1.1-.aab
161+
name: ${{ matrix.runs_on }}-${{ env.AAB_ARTIFACT_FILENAME }}
137162
path: aabs
138163

139164
macos_build_aab:
@@ -163,11 +188,18 @@ jobs:
163188
arm64_set_path_and_python_version 3.9.7
164189
brew install autoconf automake libtool openssl pkg-config
165190
make --file ci/makefiles/osx.mk
166-
- name: Build multi-arch apk Python 3 (armeabi-v7a, arm64-v8a, x86_64, x86)
191+
- name: Build multi-arch aab Python 3 (armeabi-v7a, arm64-v8a, x86_64, x86)
167192
run: |
168193
source ci/osx_ci.sh
169194
arm64_set_path_and_python_version 3.9.7
170195
make testapps-with-numpy-aab
196+
- name: Rename artifact to include the build platform name
197+
run: |
198+
mv testapps/on_device_unit_tests/${{ env.AAB_ARTIFACT_FILENAME }} ${{ matrix.runs_on }}-${{ env.AAB_ARTIFACT_FILENAME }}
199+
- uses: actions/upload-artifact@v1
200+
with:
201+
name: ${{ matrix.runs_on }}-${{ env.AAB_ARTIFACT_FILENAME }}
202+
path: ${{ matrix.runs_on }}-${{ env.AAB_ARTIFACT_FILENAME }}
171203

172204
ubuntu_rebuild_updated_recipes:
173205
name: Test updated recipes [ ubuntu-latest ]

0 commit comments

Comments
 (0)