Skip to content

Commit 8bf9651

Browse files
authored
Merge pull request #1515 from AndreMiras/feature/ticket1485_conditional_build_via_python3
Uses target python3 on conditional buids, fixes #1485
2 parents f258a92 + 12ac837 commit 8bf9651

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

ci/constants.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
class TargetPython(Enum):
55
python2 = 0
66
python3crystax = 1
7+
python3 = 2
78

89

910
# recipes that currently break the build
@@ -94,9 +95,14 @@ class TargetPython(Enum):
9495
'storm',
9596
'vlc',
9697
])
98+
# to be created via https://github.com/kivy/python-for-android/issues/1514
99+
BROKEN_RECIPES_PYTHON3 = set([
100+
])
101+
97102
BROKEN_RECIPES = {
98103
TargetPython.python2: BROKEN_RECIPES_PYTHON2,
99104
TargetPython.python3crystax: BROKEN_RECIPES_PYTHON3_CRYSTAX,
105+
TargetPython.python3: BROKEN_RECIPES_PYTHON3,
100106
}
101107
# recipes that were already built will be skipped
102108
CORE_RECIPES = set([

ci/rebuild_updated_recipes.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
```
1010
ANDROID_SDK_HOME=~/.buildozer/android/platform/android-sdk-20
1111
ANDROID_NDK_HOME=~/.buildozer/android/platform/android-ndk-r9c
12-
CRYSTAX_NDK_HOME=~/.buildozer/crystax-ndk
1312
./ci/rebuild_update_recipes.py
1413
```
1514
@@ -20,7 +19,7 @@
2019
[ERROR]: Didn't find any valid dependency graphs.
2120
[ERROR]: This means that some of your requirements pull in conflicting dependencies.
2221
- only rebuilds on sdl2 bootstrap
23-
- supports mainly python3crystax with fallback to python2, but no python3 support
22+
- supports mainly python3 with fallback to python2
2423
"""
2524
import sh
2625
import os
@@ -56,9 +55,7 @@ def build(target_python, requirements):
5655
testapp = 'setup_testapp_python2.py'
5756
android_sdk_home = os.environ['ANDROID_SDK_HOME']
5857
android_ndk_home = os.environ['ANDROID_NDK_HOME']
59-
crystax_ndk_home = os.environ['CRYSTAX_NDK_HOME']
60-
if target_python == TargetPython.python3crystax:
61-
android_ndk_home = crystax_ndk_home
58+
if target_python == TargetPython.python3:
6259
testapp = 'setup_testapp_python3.py'
6360
requirements.add(target_python.name)
6461
requirements = ','.join(requirements)
@@ -75,7 +72,7 @@ def build(target_python, requirements):
7572

7673

7774
def main():
78-
target_python = TargetPython.python3crystax
75+
target_python = TargetPython.python3
7976
recipes = modified_recipes()
8077
print('recipes modified:', recipes)
8178
recipes -= CORE_RECIPES

pythonforandroid/recipes/jedi/__init__.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
1-
21
from pythonforandroid.recipe import PythonRecipe
32

43

54
class JediRecipe(PythonRecipe):
6-
# version = 'master'
75
version = 'v0.9.0'
86
url = 'https://github.com/davidhalter/jedi/archive/{version}.tar.gz'
97

10-
depends = [('python2', 'python3crystax')]
8+
depends = [('python2', 'python3crystax', 'python3')]
119

1210
patches = ['fix_MergedNamesDict_get.patch']
1311
# This apparently should be fixed in jedi 0.10 (not released to

0 commit comments

Comments
 (0)