Skip to content

Commit b0e6310

Browse files
committed
Fix coveralls error on GitHub Actions
Coveralls started failing suddenly in GitHub Actions Worflows. This feels like a bug on their side (at least their documentation) because the `CI` environment variable is not supposed to be set refs: https://help.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables#default-environment-variables Disabling the `coveralls` conditional run from the `Makefile` fixes it. It wasn't needed as Travis already calls it explicitly without going through the `test` target. Error was: ``` /bin/sh: 1: .tox/py36/bin/coveralls: not found Makefile:30: recipe for target 'test' failed make: *** [test] Error 127 ```
1 parent b874e98 commit b0e6310

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ virtualenv: $(VIRTUAL_ENV)
2828
# ignores test_pythonpackage.py since it runs for too long
2929
test:
3030
$(TOX) -- tests/ --ignore tests/test_pythonpackage.py
31-
@if test -n "$$CI"; then .tox/py$(PYTHON_MAJOR_MINOR)/bin/coveralls; fi; \
3231

3332
rebuild_updated_recipes: virtualenv
3433
. $(ACTIVATE) && \

0 commit comments

Comments
 (0)