startForegrund now works on Android 8

Author: zworkb

pythonforandroid/bootstraps/common/build/src/main/java/org/kivy/android/PythonService.java

@@ -96,13 +96,13 @@ public int onStartCommand(Intent intent, int flags, int startId) {
     protected void doStartForeground(Bundle extras) {
         String serviceTitle = extras.getString("serviceTitle");
         String serviceDescription = extras.getString("serviceDescription");
-
         Notification notification;
         Context context = getApplicationContext();
         Intent contextIntent = new Intent(context, PythonActivity.class);
         PendingIntent pIntent = PendingIntent.getActivity(context, 0, contextIntent,
             PendingIntent.FLAG_UPDATE_CURRENT);
-        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.HONEYCOMB) {
+
+        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.O) {
             notification = new Notification(
                 context.getApplicationInfo().icon, serviceTitle, System.currentTimeMillis());
             try {
@@ -115,38 +115,27 @@ protected void doStartForeground(Bundle extras) {
                      IllegalArgumentException | InvocationTargetException e) {
             }
         } else {
-            Notification.Builder builder = new Notification.Builder(context);
+            // for android 8+ we need to create our own channel
+            // https://stackoverflow.com/questions/47531742/startforeground-fail-after-upgrade-to-android-8-1
+            String NOTIFICATION_CHANNEL_ID = "org.kivy.p4a";    //TODO: make this configurable
+            String channelName = "PythonSerice";                //TODO: make this configurable
+            NotificationChannel chan = new NotificationChannel(NOTIFICATION_CHANNEL_ID, channelName, 
+                NotificationManager.IMPORTANCE_NONE);
+            
+            chan.setLightColor(Color.BLUE);
+            chan.setLockscreenVisibility(Notification.VISIBILITY_PRIVATE);
+            NotificationManager manager = (NotificationManager) getSystemService(Context.NOTIFICATION_SERVICE);
+            assert manager != null;
+            manager.createNotificationChannel(chan);
+
+            Notification.Builder builder = new Notification.Builder(context, NOTIFICATION_CHANNEL_ID);
             builder.setContentTitle(serviceTitle);
             builder.setContentText(serviceDescription);
             builder.setContentIntent(pIntent);
             builder.setSmallIcon(context.getApplicationInfo().icon);
             notification = builder.build();
         }
-
-        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O){
-            Log.v("python service","android 8: start foregrund with new channel");
-            startForegroundWithNewChannel(1, notification);
-        }else{
-            Log.v("python service","android <8: start foregrund withut new channel");
-            startForeground(1, notification);
-        }
-    }
-
-    /**
-     * https://stackoverflow.com/questions/47531742/startforeground-fail-after-upgrade-to-android-8-1
-     *
-     * necessary because from Android 8 on we need our own channel
-     */
-    private void startForegroundWithNewChannel(int id, Notification notification){
-        String NOTIFICATION_CHANNEL_ID = "org.bd.pureservice"; //TODO: dynamically
-        String channelName = "Pureservice";
-        NotificationChannel chan = new NotificationChannel(NOTIFICATION_CHANNEL_ID, channelName, NotificationManager.IMPORTANCE_NONE);
-        chan.setLightColor(Color.BLUE);
-        chan.setLockscreenVisibility(Notification.VISIBILITY_PRIVATE);
-        NotificationManager manager = (NotificationManager) getSystemService(Context.NOTIFICATION_SERVICE);
-        assert manager != null;
-        manager.createNotificationChannel(chan);
-        startForeground(id, notification);
+        startForeground(1, notification);
     }
 
     @Override