Skip to content

Commit eb8427e

Browse files
committed
🚀 Remove orientation kwarg...
in case that we detect that p4a will build an `service_only` app. Note: if we don't do this we wil get errors once we try to create our apk with the target distribution
1 parent ba86c92 commit eb8427e

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

testapps/on_device_unit_tests/setup_test_app.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,11 @@
5858
requirements = sys.argv[n + 1].rsplit(',')
5959
break
6060

61+
# remove `orientation` in case that we don't detect a kivy or flask app,
62+
# since the `service_only` bootstrap does not support such argument
63+
if not ({'kivy', 'flask'} & set(requirements)):
64+
options['apk'].pop('orientation')
65+
6166
# write a file to let the test_app know which requirements we want to test
6267
# Note: later, when running the app, we will guess if we have the right test.
6368
app_requirements_txt = os.path.join(

0 commit comments

Comments
 (0)