Skip to content

Support ruamel.yaml, improved yaml lib. #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2018
Merged

Support ruamel.yaml, improved yaml lib. #1037

merged 3 commits into from
Nov 11, 2018

Conversation

mixmastamyk
Copy link
Contributor

@inclement
Copy link
Member

It looks like this issue was resolved in ruamel.yaml, would it be better now to just set the env var that seems to have been added?

@mixmastamyk
Copy link
Contributor Author

Yes in general, however at the time I was using this, the fix had not made it to the release version on PyPI.

Looks like it probably has by now. I'm working on backend stuff now, but hope to get back to the kivy client in a week or two, and will take a look at a newer version of a ruamel.yaml that does not need a patch.

@inclement
Copy link
Member

Okay, sorry about the delay merging this, if this hasn't made it to pypi yet just let me know and I'll merge this version.

@inclement inclement added this to the 0.7 milestone Nov 18, 2017
@AndreMiras
Copy link
Member

I gave it a try and as in last pypi version ruamel.yaml==0.15.77 the problem is still there.
I made a couple of fixes to the recipe and will merge if Travis is happy.

@AndreMiras
Copy link
Member

Conditional build is green, even though I'm not too sure why it decided to fallback to python2. Because to me all the dependencies set is also compatible with python3crystax, here is the relevant part of the log:

[INFO]:    Found 4 acceptable bootstraps: ['webview', 'service_only', 'sdl2', 'pygame']
[INFO]:    Using the first of these: webview
[INFO]:    Found a single valid recipe set: ['hostpython2', 'python2', 'setuptools', u'ruamel.yaml']
[INFO]:    -> directory context testapps/
('recipes modified:', set([u'ruamel.yaml']))
('recipes to build:', set([u'ruamel.yaml']))
incompatible with python3crystax
falling back to python2
('recipes to build (no broken):', set([u'ruamel.yaml']))
('requirements:', u'ruamel.yaml,python2')

More details: https://api.travis-ci.org/v3/job/453630101/log.txt

@AndreMiras AndreMiras merged commit 7c125ad into kivy:master Nov 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants