Skip to content

Crystax support for Feedparser #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Crystax support for Feedparser #1322

wants to merge 1 commit into from

Conversation

kuzeyron
Copy link
Contributor

@kuzeyron kuzeyron commented Aug 8, 2018

Added python3crystax to the list.

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request.
The commit title is not meaningful enough. Commit body can explain why this is needed, what error it solves

@kuzeyron kuzeyron changed the title Update __init__.py Crystax support for Feedparser Aug 9, 2018
@AndreMiras
Copy link
Member

Closing in favor of #1324
Please note that you should normally just amend your commit rather than creating a new pull request each time you need to make a little change.

@AndreMiras AndreMiras closed this Aug 9, 2018
@kuzeyron
Copy link
Contributor Author

kuzeyron commented Aug 9, 2018

@AndreMiras I couldn't find the place to change on the old one. So if I would be you, do the changes instead of having this odd game.

@AndreMiras
Copy link
Member

I cannot do the changes myself to your PR unless you explicitly give access to it.
Reading this article could help you https://medium.com/@igor_marques/git-basics-adding-more-changes-to-your-last-commit-1629344cb9a8
It's very useful trick, give it a try, it's easy once you know it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants