Update Docker base image Ubuntu Bionic 18.04 #1356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stay up to date with latest Ubuntu LTS. Also updates default target Python3 CrystaX version to 3.6.
AndreMiras
force-pushed
the
feature/update_docker_base_image_ubuntu_bionic
branch
from
bdf8cb3 to
923e5ba
Compare
AndreMiras
commented
Sep 6, 2018
| @@ -12,7 +12,7 @@ | |||
|
|
|||
|
|
|||
| class Python3Recipe(TargetPythonRecipe): | |||
| version = '3.5' | |||
| version = '3.6' | |||
There was a problem hiding this comment.
I've bumped the default to 3.6 because Python 3.5 is getting older and 3.6 is the default Python3 version of various distributions including Ubuntu 18.04 LTS.
It's still possible to force specific version with python3crystax==3.6 if needed.
AndreMiras
commented
Sep 6, 2018
| @@ -11,7 +11,7 @@ | |||
| # TODO: | |||
| # - delete archives to keep small the container small | |||
| # - setup caching (for apt, pip, ndk, sdk and p4a recipes downloads) | |||
| FROM ubuntu:16.04 | |||
| FROM ubuntu:18.04 | |||
There was a problem hiding this comment.
I think we should be up to date, mainstream, but not too cutting edge, hence the choice for the last Ubuntu LTS.
tshirtman
approved these changes
Sep 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stay up to date with latest Ubuntu LTS.