Skip to content

removed mmap from blacklist #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2018
Merged

removed mmap from blacklist #1430

merged 1 commit into from
Oct 24, 2018

Conversation

goffi-contrib
Copy link
Contributor

mmap was blacklisted, but it is actually useful, e.g. to communicate
between a frontend and a service.
This patch remove it from blacklists.

@AndreMiras
Copy link
Member

Thanks,
I've never played with mmap so I can't tell, @tito you initially blacklisted a bunch including mmap in 2b02324 can you review/merge if it's OK?
In the meantime @goffi-contrib can you simply rebase on master so CI is happy? The idea is to make a full CI run to make sure the recipes compile. Here the CI stopped because of the linter.

@tito
Copy link
Member

tito commented Oct 24, 2018

I guess it was removed because it didn't compile for android at the time. If it works today, it can be included yep.

@AndreMiras
Copy link
Member

Thanks for the feedbak tito.
Well then @goffi-contrib if you only rebase on master so we can check Travis is happy we're good to merge

mmap was blacklisted, but it is actually useful, e.g. to communicate
between a frontend and a service.
This patch remove it from blacklists.
@goffi-contrib
Copy link
Contributor Author

@AndreMiras done :)

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good thanks!

@AndreMiras AndreMiras merged commit c12dbd6 into kivy:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants