Skip to content

No need to decode into unicode when running in python 3 #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jtoledo1974
Copy link
Contributor

python-for-android fails to build when running under a python 3 interpreter with the android recipe. There is no decode method in python3 strings.

@AndreMiras
Copy link
Member

I was wondering why this was closed, but probably a twin of #1512 by misclicking or another GitHub glitch 😄

@jtoledo1974
Copy link
Contributor Author

Missed a reassignment to bootstrap_name. In all honesty I don't see the need of two different variables, bootstrap and bootstrap_name, but it's not my code so I'm just providing the most minimal change that runs the code :-)

@AndreMiras
Copy link
Member

I don't see the need either, but I haven't looked deeper.
Anyway then it's good for you to know you don't have to create a new pull request every time since it's possible to update existing ones. You can simply commit and push again.
Then you have more advanced things to do to keep the history clean, like rebasing and squashing. Take a quick look that might help for next time 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants