fix ctypes-util-find-library issue for python2 #1877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. I know it's a relatively simple change, but you know we're slowly decommissioning Python2 right? |
|
@AndreMiras I am planning to port app for python3 but somehow until app takes kivy/p4a support, we need to have full support of it as have recipe py2 so it should also have fixes for ctypes find_library :) |
AndreMiras
approved these changes
Jun 21, 2019
There was a problem hiding this comment.
Thanks for the contribution!
This is basically backporting https://github.com/kivy/python-for-android/blob/v2019.06.06/pythonforandroid/recipes/python3/patches/fix-ctypes-util-find-library.patch to python2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding patch for fixing ctypes-util-find-library issue for python2 support