Unit tests Recipe.download_file() partly #1952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inclement
previously approved these changes
Aug 5, 2019
tests/test_recipe.py
Outdated
| tempfile.TemporaryDirectory()) as temp_dir: | ||
| recipe.ctx.setup_dirs(temp_dir) | ||
| assert recipe.download_file(url, filename) == filename | ||
| assert m_urlretrieve.call_args_list == [mock.call( |
There was a problem hiding this comment.
Nicer to put mock.call on the next line with everything else.
AndreMiras
force-pushed
the
feature/unit_test_recipe_download_part2
branch
from
730e971 to
8a4f5b1
Compare
inclement
approved these changes
Aug 5, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1946.
Increases coverage by testing part of
Recipe.download_file()handlinghttps schema. Next up would be to handle more schemas in the tests.
Also addressed @opacam comments from previous pull requests.