refactoring code with For Else #2544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactoring code with For Else which is more pythonic, concise and efficient
tshirtman
approved these changes
Jan 21, 2022
|
While i think refactoring should be incidental, when needed, rather than for the sake of it, (or else we end up refactoring needlessly), this is indeed more natural, so i'm fine with it. :) |
AndreMiras
approved these changes
Jan 21, 2022
|
Ouch! That was merged into |
|
Ouch I missed that too 🤦 thanks for the heads up. |
|
It's a really minor cosmetic change, so doesn't really change anything for users that are targeting |
misl6
pushed a commit
to misl6/python-for-android
that referenced
this pull request
Jan 23, 2022
refactoring code with For Else which is more pythonic, concise and efficient
misl6
added a commit
that referenced
this pull request
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactoring code with For Else which is more pythonic, concise and efficient; how do you think this change which has practical value？